Skip to content

Conversation

@mseri
Copy link
Collaborator

@mseri mseri commented Feb 1, 2018

Signed-off-by: Marcello Seri [email protected]

@mseri mseri requested review from edwintorok and lindig February 1, 2018 13:38
@coveralls
Copy link

coveralls commented Feb 1, 2018

Coverage Status

Coverage increased (+50.5%) to 61.466% when pulling 4288609 on mseri:master into 8ab1ac7 on xapi-project:master.

@mseri mseri changed the title .coverage: bisects names are not unique CA-281880: coverage, bisects names are not unique Feb 1, 2018
Copy link
Contributor

@edwintorok edwintorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the results are better than with the old coverage script, do we know what bisect-ppx didn't like about the old script?

@mseri
Copy link
Collaborator Author

mseri commented Feb 1, 2018

Already the fact that we are running the example and showing the debug cli help is increasing the coverage. We may have also missed some files with the old script.

@mseri mseri merged commit 4e173bf into xapi-project:master Feb 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants