CP-30508: Expose iommu and hvm flags #265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
This was referenced Jan 23, 2019
lindig
approved these changes
Jan 24, 2019
Contributor
lindig
left a comment
lindig
left a comment
There was a problem hiding this comment.
This looks good. I would have avoided the _info suffix because I think it is semantically redundant.
Member
Author
I've got no strong feelings towards the suffix, after you mentioning it, I also think it's redundant |
robhoes
approved these changes
Jan 24, 2019
Member
Author
|
Grepping through xen-api bring quite a few hits on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows xapi to retrieve the information from Xen instead of roundabout methods, increasing robustness.