Improve reliability of scheduler tests #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindig
approved these changes
Feb 17, 2020
Contributor
lindig
left a comment
lindig
left a comment
There was a problem hiding this comment.
Less code and more reliable.
lippirk
reviewed
Feb 17, 2020
psafont
approved these changes
Feb 20, 2020
We got a failure in Jenkins: ``` ASSERT one_shot_success -------------------------------------------------------------------------------- [failure] Error one_shot_success: expecting true, got false. ``` The test schedules a job for 1 second in the future and then checks that it took `(0.99, 2.01) s` to run it. But the scheduler, and indeed Thread.delay cannot make such guarantees. It can only ensure that the job is scheduled *at least* 1 s in the future. If the system is busy it can take 2s, 30s, 10m, etc. the kernel provides no upper bound, this is not a real-time operating system. Replace the strict check with a timeout based one instead: wait up to a maximum allowed time, and then check how soon the callback actually got invoked (i.e. that it didn't run too early). We need the maximum allowed time because we don't want the test to be stuck forever, but we also want the test to stop as soon as the callback is executed, i.e. so it doesn't needlessly wait a minute on each test if the scheduler actually finished in 1s. Signed-off-by: Edwin Török <[email protected]>
edwintorok
force-pushed
the
private/edvint/scheduler
branch
from
3eaa923 to
8b97c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a failure in Jenkins:
The test schedules a job for 1 second in the future and then checks that
it took
(0.99, 2.01) sto run it.But the scheduler, and indeed Thread.delay cannot make such guarantees.
It can only ensure that the job is scheduled at least 1 s in the future.
If the system is busy it can take 2s, 30s, 10m, etc. the kernel provides
no upper bound, this is not a real-time operating system.
Replace the strict check with a timeout based one instead: wait up to a
maximum allowed time, and then check how soon the callback actually got
invoked (i.e. that it didn't run too early).
We need the maximum allowed time because we don't want the test to be
stuck forever, but we also want the test to stop as soon as the callback
is executed, i.e. so it doesn't needlessly wait a minute on each test if
the scheduler actually finished in 1s.
Signed-off-by: Edwin Török [email protected]