CA-310413: Unconditionally apply enic workaround (again) #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts 9d5309e. The reason is that the workaround is once again needed on the current version of the enic driver. Signed-off-by: Rob Hoes <[email protected]>
edwintorok
approved these changes
Feb 13, 2019
Contributor
edwintorok
left a comment
edwintorok
left a comment
There was a problem hiding this comment.
Would be good if the driver got a test to check it doesn't keep breaking, but that is outside of our control.
|
What testing is needed to identify this? Deli updated the driver as part of https://issues.citrite.net/browse/CP-30068 and run multiple tests at the time which passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts 9d5309e. The reason is that the
workaround is once again needed on the current version of the enic driver.
Signed-off-by: Rob Hoes [email protected]