CA-102761: To check if RPU is actually in progress before enabling HA #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siddharth Vinothkumar <[email protected]>
Contributor
Author
|
I am not sure if we could reuse Db_gc.detect_rolling_upgrade to fix the problem. |
Contributor
|
Hi Siddharth, I think we should extract the code that determines whether all host versions are the same into a new function which just returns true or false. This function could then be used both from Xapi_pool.enable_ha (to determine whether the user can enable HA) and from Db_gc.detect_rolling_upgrade (to determine whether to add or remove the Pool.other_config flag). |
use it before enabling HA. Signed-off-by: Siddharth Vinothkumar <[email protected]>
ocaml/xapi/db_gc.ml
Outdated
Contributor
There was a problem hiding this comment.
Could I suggest a tiny change? Since the platform_versions variable is now unused except in a single debug line, how about moving this line to just before that debug call?
Signed-off-by: Siddharth Vinothkumar <[email protected]>
ghost
assigned
Contributor
|
Assigning to @thomassa for review |
thomassa
added a commit
that referenced
this pull request
May 30, 2013
CA-102761: To check if RPU is actually in progress before enabling HA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Siddharth Vinothkumar [email protected]