CA-122467: Fix for setting the right value of memory_actual after vm is ... #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is started There is a race condition between vm_start and monitor thread. The monitor thread runs every 5s and updates the memory changes of the VMs if any. It does that only if the VM's resident_on value is set to localhost. Currently, the memory changes are being seen by monitor thread while VM is starting but since the start operation has'nt yet set the resident_on, the monitor thread doesn't do anything. However, the in-memory cache of monitor thread already has the vm_memory changes for that VM. This needs to be removed, so that monitor thread updates it next time when the resident_on value of the VM is set by start operation. Signed-off-by: Ravi Pandey <[email protected]>
Contributor
|
Can one of the admins verify this patch for testing? |
Contributor
|
@xen-git ok to test |
Contributor
|
Looks good to me. |
jonludlam
pushed a commit
that referenced
this pull request
Mar 4, 2014
CA-122467: Fix for setting the right value of memory_actual after vm is ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...started
There is a race condition between vm_start and monitor thread.
The monitor thread runs every 5s and updates the memory changes of the
VMs if any. It does that only if the VM's resident_on value is set to
localhost.
Currently, the memory changes are being seen by monitor thread while
VM is starting but since the start operation has'nt yet set the
resident_on, the monitor thread doesn't do anything.
However, the in-memory cache of monitor thread already has the vm_memory
changes for that VM. This needs to be removed, so that monitor thread
updates it next time when the resident_on value of the VM is set by
start operation.
Signed-off-by: Ravi Pandey [email protected]