CA-189076: Make sure perfmon wait at least the defined interval #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Code looks sensible; the comment above could do with an update so that it reflects the new behaviour :-) |
Contributor
|
Ignore my last (deleted) comment bit early and read the diff the wrong way around. |
With the current implementation, perfmon's actual idle intervals are between (defined_value - some_dither) and (defined_value + some_dither). It means that there are close to 50% cases where the actual idle/waiting periods are smaller than the defined value. This triggered an edge cases on alarm generation. When the alarm inhibite period is the same as perfmon's defined interval (i.e. the 5 min minimum), there are good chances that many alarms would be deferred until the next iteration as the inhibit period since last alarm has not fully expired (even though quite close). In cases where the same alarm should be generated continuously (at each iteration), the proportion of missing alarms would appear to be very high. This change makes sure that the actual waiting interval of perfmon covers at least the defined value. Signed-off-by: Zheng Li <[email protected]>
Contributor
Author
|
Updated wrt @johnelse's review comment, good catch! |
Contributor
|
Looks good, thanks! Ready to go in once we've unfrozen the staging branch. |
johnelse
added a commit
that referenced
this pull request
Dec 16, 2015
CA-189076: Make sure perfmon wait at least the defined interval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.