Skip to content

Conversation

@sharady
Copy link
Contributor

@sharady sharady commented Dec 15, 2015

VBD plug must fail gracefully when VM undergoing operations
like clean_shutdown, hard_shutdown, pause and suspend.

Signed-off-by: Sharad Yadav [email protected]

@robhoes
Copy link
Member

robhoes commented Dec 15, 2015

  • The error operation_not_allowed only has a single parameter ("reason")
  • If we do this, then we should also disallow VBD.unplug as well as VIF.plug/unplug for the same reason.
  • The indentation looks a bit off (I know this function is terribly indented already, but please try to "fit in").

…tions

VBD plug/unplug must fail gracefully when VM undergoing operations
like clean_shutdown, hard_shutdown, pause and suspend.

Signed-off-by: Sharad Yadav <[email protected]>
…tions

VIF plug/unplug must fail gracefully when VM undergoing operations
like clean_shutdown, hard_shutdown, pause and suspend.

Signed-off-by: Sharad Yadav <[email protected]>
@sharady
Copy link
Contributor Author

sharady commented Dec 18, 2015

Thanks @robhoes for the review. I have updated the commits, please have a look 😃

@robhoes
Copy link
Member

robhoes commented Dec 18, 2015

Looks good now, thanks.

robhoes added a commit that referenced this pull request Dec 18, 2015
CA-187691: VBD plug must fail under certain VM Lifecycle operations
@robhoes robhoes merged commit 098c548 into xapi-project:master Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants