CA-193817: Allow GVT-g even when device is hidden from xen/dom0 #2540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
n.b. More information about the required behaviour is linked from the CA ticket. |
ocaml/xapi/xapi_vgpu_type.ml
Outdated
Contributor
There was a problem hiding this comment.
The match statement means I have to keep track of what's what. Given they're all boolean values wouldn't it be jsut as clean to use if statements?
let passthrough_types =
if not is_system_display_device || not is_host_display_enabled && is_pci_hidden
then [passthrough_gpu]
else [] in
...The match case with false, _, _ and then true, [other stuff] are collapsed.
Contributor
|
I think I'll wait until your in the office to discuss the semantic change but some comments on the style above. |
Contributor
Author
|
Agreed, this could be a bit neater. Let's discuss tomorrow. |
GVT-g is now always enabled, independent of whether the device is hidden from xen/dom0. Passthrough of Intel GPUs still requires the device to be hidden from both xen and dom0. Signed-off-by: John Else <[email protected]>
Contributor
Author
|
Looks like Jenkins is a bit out of sync: |
Contributor
Author
|
I'm going to merge this, as the Jenkins build is passing now. |
johnelse
added a commit
that referenced
this pull request
Dec 17, 2015
CA-193817: Allow GVT-g even when device is hidden from xen/dom0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GVT-g is now always enabled, independent of whether the device is hidden
from xen/dom0.
Passthrough of Intel GPUs still requires the device to be hidden from
both xen and dom0.