When GuestMetrics are NULL, update_vm is partial
#2781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the upcate process to complete. We could alternatively check for `gm = Ref.null` in `update_pv_drivers_detected`, or ignore any error as done later at line `1514`. Signed-off-by: Marcello Seri <[email protected]>
Contributor
|
Ah, I was about to suggest a different fix for this... |
robhoes
pushed a commit
to robhoes/xen-api
that referenced
this pull request
Sep 27, 2016
…etric-absence When GuestMetrics are NULL, `update_vm` is partial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the update process to complete.
We could alternatively check for
gm = Ref.nullinupdate_pv_drivers_detected, or ignore any error as done later at line1514(although I would rather change that and add a debug line also at that stage).Signed-off-by: Marcello Seri [email protected]