Skip to content

Conversation

@kc284
Copy link

@kc284 kc284 commented Jul 24, 2017

…ided relevant template.

Signed-off-by: Konstantina Chremmou [email protected]

if [ ! "$1" = "--pdf" ]; then
usage() {
echo "Usage:"
echo " sh $0 [--pdf|--db]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--docbook instead of --db?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't db intuitive enough? 😝 😄
👍

@mseri
Copy link
Contributor

mseri commented Jul 24, 2017

I'd start considering converting docconvert.sh to python and use argcomplete to specify the options if we think we could add more features sooner or later. It starts getting too long for a shell script.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 14.979% when pulling 921b4da on kc284:master into 3eafb5e on xapi-project:master.

@kc284
Copy link
Author

kc284 commented Jul 25, 2017

Is python installed by default on recent linux distros (or at least on our build containers)?

@mseri
Copy link
Contributor

mseri commented Jul 25, 2017

Also in very non recent ones

Copy link
Contributor

@mseri mseri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you update this PR I will be happy to merge it.
The port from bash to python does not need to be part of it

…ided relevant template.

Signed-off-by: Konstantina Chremmou <[email protected]>
@kc284
Copy link
Author

kc284 commented Jul 28, 2017

@mseri as discussed, I changed the switch so we can merge this and I'll make at a later time a different PR to convert to python, because it requires further changes in the sdk build.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 14.971% when pulling 5d3b955 on kc284:master into 04f47f8 on xapi-project:master.

@mseri mseri merged commit 323ba8f into xapi-project:master Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants