Skip to content

Conversation

@liulinC
Copy link
Collaborator

@liulinC liulinC commented Jun 15, 2021

PBIS just disable machine account during domain leave
This commit let winbind keep this behavior for backward compatibility
instead of delete the machine account

Signed-off-by: Lin Liu [email protected]

PBIS just disable machine account during domain leave
This commit let winbind keep this behavior for backward compatibility
instead of delete the machine account

Signed-off-by: Lin Liu <[email protected]>
@liulinC liulinC requested review from lindig, lippirk and psafont June 15, 2021 05:35
@liulinC liulinC force-pushed the private/linl/winbind branch from 86ce05c to 0f514ae Compare June 17, 2021 04:23
@liulinC liulinC requested a review from lippirk June 17, 2021 04:23
@liulinC
Copy link
Collaborator Author

liulinC commented Jun 17, 2021

@lippirk @lindig @psafont Thanks for the help,
I added to new commit, could you please help to review again?

@liulinC liulinC force-pushed the private/linl/winbind branch from 0a7a2a8 to f4a5a32 Compare June 18, 2021 07:38
nss-pem-1.0.3-4.el7.x86_64
gssproxy-0.7.0-17.el7.x86_64
nss-sysinit-3.36.0-7.el7_5.x86_64
pbis-open-8.2.3-1.7.8.xs8.x86_64
Copy link
Contributor

@lippirk lippirk Jun 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have these been removed? I think these are centaurus unit tests

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to remove PBIS related packages,
I know this is just for unittest, but remove it makes no bad.

@lippirk
Copy link
Contributor

lippirk commented Jun 18, 2021

Looks fine to me, once the ocaml/tests/test_data/repository_pkg_of_fullname_all changes have been reverted

Another note is that the 'Avoid using List.hd' commit contains some unrelated changes

Copy link
Collaborator Author

@liulinC liulinC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, once the ocaml/tests/test_data/repository_pkg_of_fullname_all changes have been reverted

Another note is that the 'Avoid using List.hd' commit contains some unrelated changes

Yes, Just merged them into this commit, to avoid too many commits.
Others just some minor refine.

nss-pem-1.0.3-4.el7.x86_64
gssproxy-0.7.0-17.el7.x86_64
nss-sysinit-3.36.0-7.el7_5.x86_64
pbis-open-8.2.3-1.7.8.xs8.x86_64
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to remove PBIS related packages,
I know this is just for unittest, but remove it makes no bad.

@robhoes robhoes merged commit a705b67 into feature/winbind/master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants