-
Notifications
You must be signed in to change notification settings - Fork 297
CP-37241: Disable machine account on domain leave #4437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PBIS just disable machine account during domain leave This commit let winbind keep this behavior for backward compatibility instead of delete the machine account Signed-off-by: Lin Liu <[email protected]>
Signed-off-by: Lin Liu <[email protected]>
Signed-off-by: Lin Liu <[email protected]>
86ce05c to
0f514ae
Compare
Signed-off-by: Lin Liu <[email protected]>
0a7a2a8 to
f4a5a32
Compare
| nss-pem-1.0.3-4.el7.x86_64 | ||
| gssproxy-0.7.0-17.el7.x86_64 | ||
| nss-sysinit-3.36.0-7.el7_5.x86_64 | ||
| pbis-open-8.2.3-1.7.8.xs8.x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why have these been removed? I think these are centaurus unit tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to remove PBIS related packages,
I know this is just for unittest, but remove it makes no bad.
|
Looks fine to me, once the Another note is that the 'Avoid using List.hd' commit contains some unrelated changes |
liulinC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, once the
ocaml/tests/test_data/repository_pkg_of_fullname_allchanges have been revertedAnother note is that the 'Avoid using List.hd' commit contains some unrelated changes
Yes, Just merged them into this commit, to avoid too many commits.
Others just some minor refine.
| nss-pem-1.0.3-4.el7.x86_64 | ||
| gssproxy-0.7.0-17.el7.x86_64 | ||
| nss-sysinit-3.36.0-7.el7_5.x86_64 | ||
| pbis-open-8.2.3-1.7.8.xs8.x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to remove PBIS related packages,
I know this is just for unittest, but remove it makes no bad.
PBIS just disable machine account during domain leave
This commit let winbind keep this behavior for backward compatibility
instead of delete the machine account
Signed-off-by: Lin Liu [email protected]