REQ-403 concurrency fixes part 1 #4441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 21, 2021 16:16
This fixes parallel Pool.ejects - if we try to eject host B, but host C is not contactable, we do not want to block the eject. The price we pay for parallel ejects is that we might not clean up host B's certificates on host C. Signed-off-by: Ben Anson <[email protected]>
This prevents concurrent cert distribs interfering with each other. Pool.join caveat: during a join, the joiner modifies /etc/stunnel itself. This cannot be locked by the master, so some race conditions still remain. Additionally, the joiner goes offline for a portion of the join, so could lose out on certificate updates during this time, especially if multiple pool joins are happening at the same time. Signed-off-by: Ben Anson <[email protected]>
Contributor
Author
|
@lindig eventually the cert refresh code will need to be locked with this mutex. I don't mind adding it later, but worth keeping in mind |
Member
|
This looks reasonable to me, has this been tested? |
psafont
approved these changes
Jun 21, 2021
Contributor
Author
I've tested pool join, eject and verification enable manually |
robhoes
approved these changes
Jun 22, 2021
lindig
approved these changes
Jun 23, 2021
| * we apply this lock to all top level distribution calls, with the exception of | ||
| * the pool join functions that execute on the joiner. | ||
| *) | ||
| let lock (f : unit -> 'a) : 'a = |
Contributor
There was a problem hiding this comment.
How about with_lock or locked as a name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes parallel pool.ejects, and makes cert distribs a bit safer
Additional improvements (for a later PR):