Skip to content

CP-37590: Replace negative language with bond/pool member #4508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 31, 2021
Merged

CP-37590: Replace negative language with bond/pool member #4508

merged 2 commits into from
Aug 31, 2021

Conversation

@danilo-delbusso
Copy link
Member

@danilo-delbusso danilo-delbusso commented Aug 26, 2021 •
edited
Loading

Other changes to negative terms were excluded as not relevant to the ticket.

Please also review xen-api-sdk#189

@danilo-delbusso
CP-37590: Replaced negative language with bond member
1b4e446 
Other changes to negative terms were excluded as not relevant to the ticket.

Signed-off-by: Danilo Del Busso <[email protected]>
@danilo-delbusso danilo-delbusso mentioned this pull request Aug 26, 2021
Merged
@danilo-delbusso danilo-delbusso changed the title CP-37590: Replaced negative language with bond member CP-37590: Replaced negative language with bond/pool member Aug 26, 2021
@danilo-delbusso danilo-delbusso mentioned this pull request Aug 26, 2021
Merged
@danilo-delbusso danilo-delbusso changed the title CP-37590: Replaced negative language with bond/pool member CP-37590: Replace negative language with bond/pool member Aug 26, 2021
lindig
lindig reviewed Aug 27, 2021
View reviewed changes
@lindig
Copy link
Contributor

lindig commented Aug 31, 2021

I can't see how the change is related to the build failure.

52 |     | Rpc.Base64 t -> sprintf "Rpc.Base64 %s" t in
           ^^^^^^^^^^
Error: Unbound constructor Rpc.Base64

This is the Stockholm branch and I like to believe that we would have noticed any failure here earlier.

@lindig
Copy link
Contributor

lindig commented Aug 31, 2021

We merged previously: #4504 and it looks to me like tests were not run and this could have missed the problem.

@lindig
Copy link
Contributor

lindig commented Aug 31, 2021

Indeed, the test on #4504 failed but it was not obvious enough.

@lindig
Copy link
Contributor

lindig commented Aug 31, 2021

I will merge this because the failure is unrelated.

@lindig lindig merged commit d4a66b6 into xapi-project:1.249-lcm Aug 31, 2021
@danilo-delbusso danilo-delbusso deleted the 1.249-lcm branch August 31, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lindig lindig lindig approved these changes

@kc284 kc284 kc284 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danilo-delbusso @lindig @kc284