Skip to content

IH-633: Transition away from exception-raising Hashtbl.find and Unix.getenv #5751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
last-genius merged 6 commits into from
Jul 8, 2024
Merged

IH-633: Transition away from exception-raising Hashtbl.find and Unix.getenv #5751

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99c4356
Transition from exception-raising Unix.getenv to Sys.getenv_opt with
Jun 19, 2024
7be240f
Replace Hashtbl.find with Hashtbl.find_opt in trivial cases
Jun 26, 2024
1869b44
Refactor Hashtbl.find out of resources/table.ml
Jun 26, 2024
47f3c3d
Refactor Hashtbl.find out of xenopsd/xc/readln.ml
Jun 26, 2024
d4be15e
Add a gate for Hashbtl.find
Jun 27, 2024
76f232d
Merge branch 'master' into private/asultanov/opt-refactoring
last-genius Jul 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add a gate for Hashbtl.find 
Signed-off-by: Andrii Sultanov <[email protected]>
  • Loading branch information
Andrii Sultanov committed Jul 4, 2024
commit d4be15e09702ab5be5bf68c7a2b786a0883b0758
14 changes: 14 additions & 0 deletions quality-gate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,19 @@ unixgetenv () {
fi
}

hashtblfind () {
N=36
# Looks for all .ml files except the ones using Core.Hashtbl.find,
# which already returns Option
HASHTBLFIND=$(git grep -P -r --count 'Hashtbl.find(?!_opt)' -- '**/*.ml' ':!ocaml/xapi-storage-script/main.ml' | cut -d ':' -f 2 | paste -sd+ - | bc)
if [ "$HASHTBLFIND" -eq "$N" ]; then
echo "OK counted $HASHTBLFIND usages of exception-raising Hashtbl.find"
else
echo "ERROR expected $N usages of exception-raising Hashtbl.find, got $HASHTBLFIND" 1>&2
exit 1
fi
}

list-hd
verify-cert
mli-files
Expand All @@ -112,4 +125,5 @@ vtpm-unimplemented
vtpm-fields
ocamlyacc
unixgetenv
hashtblfind