-
Notifications
You must be signed in to change notification settings - Fork 297
Remove python2 related CI #5908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
liulinC
merged 2 commits into
xapi-project:feature/py3
from
stephenchengCloud:private/stephenche/remove_python2_CI
Aug 5, 2024
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Remove python2 related CI
Signed-off-by: Stephen Cheng <[email protected]>
- Loading branch information
commit c8d9d1322e43f49b2383ce170dd5379f35f90a60
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ jobs: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| python-version: ["2.7", "3.11"] | ||
| python-version: ["3.11"] | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
@@ -39,24 +39,11 @@ jobs: | |
|
|
||
| - uses: pre-commit/[email protected] | ||
| name: Run pre-commit checks (no spaces at end of lines, etc) | ||
| if: ${{ matrix.python-version != '2.7' }} | ||
| with: | ||
| extra_args: --all-files --verbose --hook-stage commit | ||
| env: | ||
| SKIP: no-commit-to-branch | ||
|
|
||
| - name: Run Pytest for python 2 and get code coverage | ||
| if: ${{ matrix.python-version == '2.7' }} | ||
| run: > | ||
| pip install enum future mock pytest-coverage pytest-mock && | ||
| pytest -vv -rA --cov=ocaml ocaml | ||
| --cov-report term-missing | ||
| --cov-report xml:.git/coverage${{matrix.python-version}}.xml | ||
| --cov-fail-under 50 | ||
| env: | ||
| PYTHONDEVMODE: yes | ||
| PYTHONPATH: "python3:python3/stubs" | ||
|
|
||
| - name: Upload coverage report to Coveralls | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
|
|
@@ -66,7 +53,6 @@ jobs: | |
| parallel: true | ||
|
|
||
| - uses: dciborow/[email protected] | ||
| if: ${{ matrix.python-version != '2.7' }} | ||
| with: | ||
| reporter: github-pr-review | ||
| level: warning | ||
|
|
@@ -75,7 +61,6 @@ jobs: | |
| continue-on-error: true | ||
|
|
||
| - name: Run pytype checks | ||
| if: ${{ matrix.python-version != '2.7' }} | ||
| run: pip install pandas pytype toml && ./pytype_reporter.py | ||
| env: | ||
| PR_NUMBER: ${{ github.event.number }} | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.