CA-407370: Use remote.conf for customer rsyslog forwarding rules #6328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldEV
force-pushed
the
private/geralde/CA-407370
branch
2 times, most recently
from
f81e0a6 to
275ba90
Compare
Author
|
Latest commit(s) to apply comment and make the script more tolerant (using -f) |
lindig
reviewed
Feb 27, 2025
GeraldEV
force-pushed
the
private/geralde/CA-407370
branch
from
275ba90 to
48f8086
Compare
Author
|
Thanks for the comments, also spotted replacing the service as a result of the testing :D |
GeraldEV
changed the title
lindig
approved these changes
Feb 28, 2025
psafont
reviewed
Mar 3, 2025
robhoes
approved these changes
Mar 3, 2025
psafont
approved these changes
Mar 6, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Gerald Elder-Vass <[email protected]>
GeraldEV
force-pushed
the
private/geralde/CA-407370
branch
from
e07e261 to
468eb75
Compare
Author
|
Squashed commits, waiting for builds before merging (re-tested just for sanity sake after the squash) |
rosslagerwall
approved these changes
Mar 6, 2025
psafont
added a commit
to xcp-ng/xen-api
that referenced
this pull request
Oct 21, 2025
Xenserver's changes around rsyslog configuration have downsides and the packaging prefers the previous behaviour because there's no time to properly fix the behaviour before the next release. For the original change, see xapi-project#6328 Discussions on why the original change is dubious: xcp-ng-rpms/xcp-ng-release#33 Reverts commit 468eb75. Signed-off-by: Pau Ruiz Safont <[email protected]>
psafont
added a commit
to xcp-ng/xen-api
that referenced
this pull request
Nov 26, 2025
Xenserver's changes around rsyslog configuration have downsides and the packaging prefers the previous behaviour because there's no time to properly fix the behaviour before the next release. For the original change, see xapi-project#6328 Discussions on why the original change is dubious: xcp-ng-rpms/xcp-ng-release#33 Reverts commit 468eb75. Signed-off-by: Pau Ruiz Safont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XenServer does not protect
/etc/rsyslog.d/xenserver.confwhen updating the rsyslog package (or the xenserver-release package on CH8.2CU1), as a result it is replaced with a fresh instance during updates which will lose customer configurations (if they have any).This script is primarily invoked via XenCenter when providing a new host for log forwarding.
An update will be made to the XenServer rsyslog package to make it clear that
/etc/rsyslog.d/xenserver.confshould not be edited by the customer.I've tested this by copying the updated script onto my DT box and using XenCenter to add a new log server - noting the new
/etc/rsyslog.d/custom.conffile and the untouched/etc/rsyslog.d/xenserver.conffile.