Skip to content

Run static analysis on OCaml C stubs in the CI #6338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edwintorok merged 5 commits into from
Mar 5, 2025
Merged

Run static analysis on OCaml C stubs in the CI #6338

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b97788b
CI: add a codechecker workflow
edwintorok Apr 25, 2024
6ee60f1
[maintenance] xa_auth.h: avoid using reserved macro names
edwintorok Feb 21, 2025
2a0350f
unixpwd.c: fix error path file descriptor leak
edwintorok Feb 21, 2025
299cb6f
[maintenance] syslog_stubs.c: avoid using reserved identifier names
edwintorok Feb 21, 2025
23e01d7
[maintenance] blkgetsize64: avoid warning about uninit value
edwintorok Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
unixpwd.c: fix error path file descriptor leak 
Fixes a warning reported by codechecker

Signed-off-by: Edwin Török <[email protected]>
  • Loading branch information
@edwintorok
edwintorok committed Mar 4, 2025
commit 2a0350ff0bd3c0d81a8504f86fdae07049a1c0e8
4 changes: 3 additions & 1 deletion unixpwd/c/unixpwd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ unixpwd_setspw(const char *user, char *password)
*sp;
char buf[BUFLEN];
int tmp;
FILE *tmp_file;
FILE *tmp_file = NULL;
char tmp_name[PATH_MAX];
struct stat statbuf;
int rc;
Expand All @@ -164,6 +164,8 @@ unixpwd_setspw(const char *user, char *password)
return rc;
}
if (lckpwdf() != 0) {
if (tmp_file)
fclose(tmp_file);
close(tmp);
unlink(tmp_name);
return ENOLCK;
Expand Down