xapi-stdext-date: replace all usages to use clock instead #6358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not deleting the package and aliasing its main type to Clock.Date.t allows for a smooth transition. Signed-off-by: Pau Ruiz Safont <[email protected]>
changlei-li
approved these changes
Mar 14, 2025
Contributor
changlei-li
left a comment
changlei-li
left a comment
There was a problem hiding this comment.
A small one: In some dune/opam files, the alphabetical order is broken after modifying
last-genius
approved these changes
Mar 14, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not deleting the package and aliasing its main type to Clock.Date.t allows for a smooth transition.
In particular xenserver's license and clustering daemons can build without any source changes.
Once this has been merge I'll open respective PRs to use Clock.Date.t, and another one to update xs-opam metadata, after which Xapi_stdext_date can be dropped completely.