-
Notifications
You must be signed in to change notification settings - Fork 295
IPv6 IPs in host certificates for dual-stack management interfaces #6419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We have tests here which can install two hosts in IPv6 and then join them in a pool. Would this be a sufficient check? (However running them is not really straightforward at the moment, so a manual test might be better for this PR. For future regression testing with IPv6, my question remains) |
I think so, yes. Do the test also inspect certificates? |
lindig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extended and clever use of Option.fold
I don't think so. Also we don't test dual stack yet 😬 (seen the title update) |
I will test it manually then on Monday |
|
xapi on a dualstack host without this PR: with this PR: |
|
I didn't expect the issuer and the subject to change. I'm not sure what we want to do here, at some level it makes sense to use the DNS name if possible, the IPs are still available in the SAN anyway. I checked the code, and the hsotname should be preferred since 2021, in 7ca6ea4 |
00f37d3 to
b2cfaa1
Compare
This will be important to have a dual-stack mode Signed-off-by: Pau Ruiz Safont <[email protected]>
b2cfaa1 to
121be30
Compare
This is done for host certificates only Signed-off-by: Pau Ruiz Safont <[email protected]>
Signed-off-by: Pau Ruiz Safont <[email protected]>
121be30 to
d94a4bf
Compare
Adds IPv6 addresses to host certificates when their management interfaces are configured to use Dual stack.
I've tested manually on IPv4-only hosts, and the certificates are generated in the same way as before.
I've run the smoke and verification tests (Suite Run 215863), all of them passed
@last-genius you probably want to test these changes, run
openssl x509 -text -in /etc/xensource/xapi-ssl.pemon a dual host, and see that it contains the IPv6 and IPv4 addresses.