Skip to content

s/xe-syslog-reconfigure: Keep disclaimer in remote.conf #6774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lindig merged 1 commit into from
Dec 1, 2025
Merged

s/xe-syslog-reconfigure: Keep disclaimer in remote.conf #6774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
s/xe-syslog-reconfigure: Keep disclaimer in remote.conf 
The behaviour is same, except that the file will remain (with empty
rules) even if the forwarding log has been disabled (and then prevent
the disclaimer loss).

Wording slightly modified to reduce the risk of concurrent management
of this file, if the file is still edited by other mean, it will be
done knowingly (that x-s-r may override any change soon or later).

For the record remote.conf was introduced in:
468eb75 .

I am assuming that the presence of file is not checked elsewhere that
in xen-api (currently only s/x-s-r is referencing this file).

Signed-off-by: Philippe Coval <[email protected]>
  • Loading branch information
@rzr
rzr committed Nov 28, 2025
commit 19e5c076ef737e7389bcfb5378a0ad1855c7325c
4 changes: 1 addition & 3 deletions scripts/xe-syslog-reconfigure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,9 @@ do
done


echo "# /etc/rsyslog.d/remote.conf is managed by xe-syslog-reconfigure (do not edit)" > /etc/rsyslog.d/remote.conf
if [ $remote -eq 1 ]; then
echo "# /etc/rsyslog.d/remote.conf is auto-generated by xe-syslog-reconfigure" > /etc/rsyslog.d/remote.conf
echo "*.* @$host" >> /etc/rsyslog.d/remote.conf
else
rm -f /etc/rsyslog.d/remote.conf
fi

systemctl restart rsyslog
Loading