Apps review 2#790
Open
Rigidity wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches bridge dispatch, approval resolution, and wallet/secret bridge methods; behavior change if anything relied on approving non-user pending requests or the old dynamic registry path.
Overview
This PR refactors the Sage apps bridge and related host code: it drops
async-trait/erased-serde, replaces dynamicBridgeMethodtrait objects with typed user/system registries andBridgeMethodHandler, and standardizes handler results asserde_json::Valueviabridge_result.Bridge approval resolution no longer re-enters the generic shared executor for approved calls; it only runs user-bridge methods through
UserBridgeRegistry(execute_approved_user_bridge_request), and rejects resolving non-user pending approvals.App lifecycle mutations use
AsyncFnOnceinstead ofBox::pinfutures; install sources use nativeimpl Futuretraits. Sandbox modules are re-exported at the crate root with broaderpub(crate)probe APIs, and several import paths are flattened.Reviewed by Cursor Bugbot for commit e0d1648. Bugbot is set up for automated code reviews on this repo. Configure here.