fix memory leak in SnappyOutputStream #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xerial
added a commit
that referenced
this pull request
Oct 26, 2014
fix memory leak in SnappyOutputStream
xerial
added a commit
that referenced
this pull request
Oct 26, 2014
Owner
|
Thanks for finding this mistake. Just released 1.1.1.6. |
Contributor
|
Maybe we should add a test to catch large-scale memory leaks like this. One idea would be to write a test that compresses, say, a 2 gigabyte stream into /dev/null, which I think would expose leaks like this. |
Owner
|
Sounds good. A more elaborated approach would be counting the total allocated/released memory sizes, and check their difference in a test case. |
asfgit
pushed a commit
to apache/spark
that referenced
this pull request
Nov 16, 2014
This upgrades snappy-java to 1.1.1.6, which includes a patch that improves error messages when attempting to deserialize empty inputs using SnappyInputStream (see xerial/snappy-java#89). We previously tried up upgrade to 1.1.1.5 in #2911 but reverted that patch after discovering a memory leak in snappy-java. This should leak have been fixed in 1.1.1.6, though (see xerial/snappy-java#92). Author: Josh Rosen <[email protected]> Closes #3287 from JoshRosen/SPARK-4419 and squashes the following commits: 5d6f4cc [Josh Rosen] [SPARK-4419] Upgrade snappy-java to 1.1.1.6.
asfgit
pushed a commit
to apache/spark
that referenced
this pull request
Nov 16, 2014
This upgrades snappy-java to 1.1.1.6, which includes a patch that improves error messages when attempting to deserialize empty inputs using SnappyInputStream (see xerial/snappy-java#89). We previously tried up upgrade to 1.1.1.5 in #2911 but reverted that patch after discovering a memory leak in snappy-java. This should leak have been fixed in 1.1.1.6, though (see xerial/snappy-java#92). Author: Josh Rosen <[email protected]> Closes #3287 from JoshRosen/SPARK-4419 and squashes the following commits: 5d6f4cc [Josh Rosen] [SPARK-4419] Upgrade snappy-java to 1.1.1.6. (cherry picked from commit 7d8e152) Signed-off-by: Reynold Xin <[email protected]>
ayappanec
pushed a commit
to ayappanec/snappy-java
that referenced
this pull request
Dec 5, 2014
ayappanec
pushed a commit
to ibmsoe/snappy-java
that referenced
this pull request
Dec 5, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.