-
-
Notifications
You must be signed in to change notification settings - Fork 494
Auto-update libmem to 5.1.1 #8784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the update of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated update for the libmem package to version 5.1.1. The change correctly adds the new version and its hash. My review has identified a potential issue where a patch specific to version 5.1.0 for FreeBSD is not being applied to the new 5.1.1 version. This could result in build or runtime problems on FreeBSD if the patch's fixes are still relevant. Details are in the specific comment.
|
|
||
| add_urls("https://github.com/rdbo/libmem/archive/refs/tags/$(version).tar.gz", | ||
| "https://github.com/rdbo/libmem.git", {submodules = false}) | ||
| add_versions("5.1.1", "1e92954e2253fab34acd5c1df3c3ac2765803f10ee00aea4068b37de9550193a") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The patch for version 5.1.0 (patches/5.1.0/fix-freebsd.diff, defined on line 15) is not applied to this new version 5.1.1 due to its specific version constraint. If the fixes contained in that patch are still necessary for version 5.1.1, their absence could lead to build failures or runtime issues on the FreeBSD platform. If the patch is still required, its version applicability should be extended to include 5.1.1.
New version of libmem detected (package version: 5.1.0, last github version: 5.1.1)