Travis CI: Test on Python 3.8 production release #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also drop the EOL Python 3.4 @hugovk Your review please.
hugovk
approved these changes
Nov 9, 2019
Contributor
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
I don't have merge rights here, but looks good!
nitzmahone
approved these changes
Dec 2, 2019
perlpunk
approved these changes
Dec 2, 2019
Member
|
thanks, merged! |
Member
|
released https://pypi.org/project/PyYAML/5.3/ |
stealthycoin
added a commit
to stealthycoin/aws-cli
that referenced
this pull request
Feb 28, 2020
PyYAML 5.3 dropped support for python 3.4. yaml/pyyaml#345
stealthycoin
added a commit
to stealthycoin/aws-cli
that referenced
this pull request
Feb 28, 2020
PyYAML 5.3 dropped support for python 3.4. yaml/pyyaml#345
Totktonada
added a commit
to tarantool/tarantool-python
that referenced
this pull request
Aug 21, 2020
`pip install pyyaml` fails in AppVeyor on 64-bit Python 3.4 with the following message (full log is in [1]): | Collecting pyyaml | Downloading <...>/PyYAML-5.3.1.tar.gz (269kB) | <...> | building '_yaml' extension | Traceback (most recent call last): | <...> | File "C:\Python34-x64\lib\distutils\msvc9compiler.py", line 287, in query_vcvarsall | raise ValueError(str(list(result.keys()))) | ValueError: ['path'] It is cumulative effect of several problems. The first one is that pip does not choose a PyYAML version, which supports given Python version (it is PyYAML 5.2, see [2]), but tries to install a last one (it is PyYAML 5.3.1 ATM). There are PyYAML issues [3], [4] and [5], which are not exacly about this, but looks tightly related. Despite Python 3.4 is not officially supported in PyYAML, it works on 3.4 in fact, so it is not the problem per se. Next, there are no wheels for Python 3.4 for PyYAML 5.3.1 on PyPI (which is logical), so pip downloads the source tarball and tries to build it. And the exception shown above is raised. It looks similar to [6], so I would guess that it is a compiler setup problem within an AppVeyor Windows image. I started the discussion [7] regarding it, but we need to work the problem around. Side note: 32-bit Python 3.4 works fine, the problem appears only for the 64-bit Python 3.4 build. In order to workaround the compiler setup problem we can just choose a PyYAML version for which PyPI provides wheels for the corresponding platform / Python version / Python build. It is 5.2b1, see [8]. Python 3.4 reaches EOL 2019-03-18 with releasing 3.4.10 (see [9]). I would not consider it as the reason to drop support of it on our side, especially when we're tell about a library (our users has its users, etc) and it is hard to estimate the impact. The problem we meet here is just about a testing dependency in a particular environment. So let's keep Python 3.4 support until there will be a better reason to stop. [1]: https://ci.appveyor.com/project/tarantool/tarantool-python/builds/34769695/job/ww3s69pkuh1n9d1y [2]: yaml/pyyaml#345 [3]: yaml/pyyaml#281 [4]: yaml/pyyaml#375 [5]: yaml/pyyaml#398 [6]: https://stackoverflow.com/a/43711372/1598057 [7]: http://help.appveyor.com/discussions/problems/28023 [8]: https://pypi.org/project/PyYAML/5.2b1/#files [9]: https://www.python.org/downloads/release/python-3410/
Totktonada
added a commit
to tarantool/tarantool-python
that referenced
this pull request
Aug 21, 2020
`pip install pyyaml` fails in AppVeyor on 64-bit Python 3.4 with the following message (full log is in [1]): | Collecting pyyaml | Downloading <...>/PyYAML-5.3.1.tar.gz (269kB) | <...> | building '_yaml' extension | Traceback (most recent call last): | <...> | File "C:\Python34-x64\lib\distutils\msvc9compiler.py", line 287, in query_vcvarsall | raise ValueError(str(list(result.keys()))) | ValueError: ['path'] It is cumulative effect of several problems. The first one is that pip does not choose a PyYAML version, which supports given Python version (it is PyYAML 5.2, see [2]), but tries to install a last one (it is PyYAML 5.3.1 ATM). There are PyYAML issues [3], [4] and [5], which are not exacly about this, but looks tightly related. Despite Python 3.4 is not officially supported in PyYAML, it works on 3.4 in fact, so it is not the problem per se. Next, there are no wheels for Python 3.4 for PyYAML 5.3.1 on PyPI (which is logical), so pip downloads the source tarball and tries to build it. And the exception shown above is raised. It looks similar to [6], so I would guess that it is a compiler setup problem within an AppVeyor Windows image. I started the discussion [7] regarding it, but we need to work the problem around. Side note: 32-bit Python 3.4 works fine, the problem appears only for the 64-bit Python 3.4 build. In order to workaround the compiler setup problem we can just choose a PyYAML version for which PyPI provides wheels for the corresponding platform / Python version / Python build. It is 5.2b1, see [8]. Python 3.4 reaches EOL 2019-03-18 with releasing 3.4.10 (see [9]). I would not consider it as the reason to drop support of it on our side, especially when we're tell about a library (our users has its users, etc) and it is hard to estimate the impact. The problem we meet here is just about a testing dependency in a particular environment. So let's keep Python 3.4 support until there will be a better reason to stop. [1]: https://ci.appveyor.com/project/tarantool/tarantool-python/builds/34769695/job/ww3s69pkuh1n9d1y [2]: yaml/pyyaml#345 [3]: yaml/pyyaml#281 [4]: yaml/pyyaml#375 [5]: yaml/pyyaml#398 [6]: https://stackoverflow.com/a/43711372/1598057 [7]: http://help.appveyor.com/discussions/problems/28023 [8]: https://pypi.org/project/PyYAML/5.2b1/#files [9]: https://www.python.org/downloads/release/python-3410/
Totktonada
added a commit
to tarantool/tarantool-python
that referenced
this pull request
Aug 21, 2020
`pip install pyyaml` fails in AppVeyor on 64-bit Python 3.4 with the following message (full log is in [1]): | Collecting pyyaml | Downloading <...>/PyYAML-5.3.1.tar.gz (269kB) | <...> | building '_yaml' extension | Traceback (most recent call last): | <...> | File "C:\Python34-x64\lib\distutils\msvc9compiler.py", line 287, in query_vcvarsall | raise ValueError(str(list(result.keys()))) | ValueError: ['path'] It is cumulative effect of several problems. The first one is that pip does not choose a PyYAML version, which supports given Python version (it is PyYAML 5.2, see [2]), but tries to install a last one (it is PyYAML 5.3.1 ATM). There are PyYAML issues [3], [4] and [5], which are not exacly about this, but looks tightly related. Despite Python 3.4 is not officially supported in PyYAML, it works on 3.4 in fact, so it is not the problem per se. Next, there are no wheels for Python 3.4 for PyYAML 5.3.1 on PyPI (which is logical), so pip downloads the source tarball and tries to build it. And the exception shown above is raised. It looks similar to [6], so I would guess that it is a compiler setup problem within an AppVeyor Windows image. I started the discussion [7] regarding it, but we need to work the problem around. Side note: 32-bit Python 3.4 works fine, the problem appears only for the 64-bit Python 3.4 build. In order to workaround the compiler setup problem we can just choose a PyYAML version for which PyPI provides wheels for the corresponding platform / Python version / Python build. It is 5.2b1, see [8]. Python 3.4 reaches EOL 2019-03-18 with releasing 3.4.10 (see [9]). I would not consider it as the reason to drop support of it on our side, especially when we're tell about a library (our users has its users, etc) and it is hard to estimate the impact. The problem we meet here is just about a testing dependency in a particular environment. So let's keep Python 3.4 support until there will be a better reason to stop. [1]: https://ci.appveyor.com/project/tarantool/tarantool-python/builds/34769695/job/ww3s69pkuh1n9d1y [2]: yaml/pyyaml#345 [3]: yaml/pyyaml#281 [4]: yaml/pyyaml#375 [5]: yaml/pyyaml#398 [6]: https://stackoverflow.com/a/43711372/1598057 [7]: http://help.appveyor.com/discussions/problems/28023 [8]: https://pypi.org/project/PyYAML/5.2b1/#files [9]: https://www.python.org/downloads/release/python-3410/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also drop the EOL Python 3.4 @hugovk Your review please.