feat: Improve Bash script based on feedback#185
Open
Adriel007 wants to merge 2 commits intoyandex:devfrom
Open
feat: Improve Bash script based on feedback#185Adriel007 wants to merge 2 commits intoyandex:devfrom
Adriel007 wants to merge 2 commits intoyandex:devfrom
Conversation
This commit enhances the Bash script according to provided feedback: - Improved error handling by initializing the 'fail' variable before usage. - Replaced 'find' with a 'while' loop to handle directory paths with spaces. - Added validation after changing to the project's root directory. - Updated documentation to reflect the changes made. Further enhancements, such as command and Go installation validation checks, are recommended.
Contributor
|
Hi Adriel! |
Author
Ah, okay, thanks for the advice |
Author
|
I just fixed and pushed the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script Documentation
This document outlines the improvements made to the Bash script based on the provided feedback.
Error Handling
set -o errexitandset -o pipefail, ensuring better error handling. However, the variablefailwas used without initialization. Now,failis initialized before usage.Directory Path Handling
find, which can be problematic with spaces in file or directory names, awhileloop withreadis utilized. TheIFS(Internal Field Separator) is modified to handle spaces.Temporary File Handling
Directory Validation
Command and Go Installation Validation
gover,gitandgo, as well as proper installation of Go.Script Changes Summary
failvariable locally before usage.findwith awhileloop to handle directory paths with spaces.Script Overview
The script performs the following tasks:
Note: It's advisable to further enhance the script with command and Go installation validation checks.