Skip to content

Conversation

@fsmanuel
Copy link
Collaborator

The readme states that version > 1.0.1 requires ember >= 3.8 and the polyfill is only used for emberVersion.lt('3.1.0'):
https://github.com/rondale-sc/ember-notify-property-change-polyfill/blob/master/index.js#L13

So I think it's save to remove the dependency. That also removes this deprecation:
Bildschirmfoto 2022-05-11 um 13 13 50

fsmanuel added 3 commits May 11, 2022 13:27
The readme states that version `> 1.0.1` requires ember `>= 3.8` and the polyfill is only used for `emberVersion.lt(‚3.1.0‘)`:
https://github.com/rondale-sc/ember-notify-property-change-polyfill/blob/master/index.js#L13
As the addon only provides the proxy and mixin we don’t need `ember-cli-htmlbars` to be a dependency
@fsmanuel fsmanuel requested a review from lukemelia May 11, 2022 11:31
@fsmanuel fsmanuel self-assigned this May 11, 2022
@fsmanuel
Copy link
Collaborator Author

@lukemelia
Our tests fail for ember 3.8 because we use @action decorators:
https://github.com/yapplabs/ember-buffered-proxy/runs/6387142409?check_suite_focus=true

For ember 3.12 one test is failing because tracked properties were introduced in 3.13:
https://github.com/yapplabs/ember-buffered-proxy/runs/6387142489?check_suite_focus=true

I think everything should work for 3.12 if you use @computed decorators but the effort to cover it in the tests is to much. So I updated the readme to reflect the compatibility.

@lukemelia lukemelia merged commit a1ec95f into yapplabs:master May 11, 2022
@lukemelia lukemelia added dependencies Pull requests that update a dependency file internal labels May 11, 2022
@lukemelia
Copy link
Contributor

Released as 2.1.1

@fsmanuel fsmanuel deleted the cleanup-dependencies branch May 11, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants