Skip to content

Conversation

@paul-soporan
Copy link
Member

@paul-soporan paul-soporan commented Jul 7, 2020

What's the problem this PR addresses?

Currently, there's a lot of duplication in our lockfile. (Descriptors with overlapping ranges being resolved and locked to different locators)

How did you fix it?

I created a quick (and slow & buggy & inefficient) yarn deduplicate command inspired by yarn-plugin-deduplicate (which currently has quite a few not-so-small problems that unfortunately make it unusable, so I decided to write my own implementation) and I ran it on our repository.
(I've only committed the results, not the command itself, I'm not sure where it's the best place for it to live once it's optimized, but I'm going to guess that not on our repository, even though it would definitely be a very useful feature. Any thoughts about this? 🤔 )

Out of curiosity, I've also collected the stats:

Cache file count Cache size Lockfile size .pnp.js size Bundle size
Before 2,939 Files 216.9 MB 1.0 MB 2.0 MB 2.35 MB
After 2,704 Files 163.9 MB 961.4 KB 1.9 MB 2.33 MB

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I have verified that all automated PR checks pass.

@arcanis arcanis merged commit d851da6 into master Jul 7, 2020
@arcanis arcanis deleted the paul/chore/deduplicate-deps branch July 7, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants