Skip to content

perf(plugin-npm): use cached range in NpmSemverResolver.getSatisfying #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arcanis merged 1 commit into from
Aug 23, 2020
Merged

perf(plugin-npm): use cached range in NpmSemverResolver.getSatisfying #1744

arcanis merged 1 commit into from
Aug 23, 2020

Conversation

@merceyz
Copy link
Member

@merceyz merceyz commented Aug 23, 2020

What's the problem this PR addresses?

NpmSemverResolver.getSatisfying doesn't use the cached semver range because #1558 was merged 2 minutes after the semver range cached was merged

How did you fix it?

Make NpmSemverResolver.getSatisfying use semverUtils.validRange which caches the result

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I have verified that all automated PR checks pass.

@arcanis arcanis merged commit 0604dc3 into master Aug 23, 2020
@arcanis arcanis deleted the merceyz/perf-getSatisfying branch August 23, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paul-soporan paul-soporan paul-soporan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@merceyz @paul-soporan @arcanis