Skip to content

feat(npm-cli): add npmAuditRegistry config option #3583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 3 commits into from
Oct 20, 2021
Merged

feat(npm-cli): add npmAuditRegistry config option #3583

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
29ecdd4
feat(npm-cli): add npmAuditRegistry config option
jdanil Oct 17, 2021
686cb9f
fix(npm): getAuditRegistry fallback to publish registry
jdanil Oct 18, 2021
061a324
Versions
arcanis Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(npm): getAuditRegistry fallback to publish registry
  • Loading branch information
@jdanil
jdanil authored Oct 18, 2021
commit 686cb9fde3986074a72af1bb01a9e01742a4fe86
7 changes: 6 additions & 1 deletion packages/plugin-npm/sources/npmConfigUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,13 @@ export function normalizeRegistry(registry: string) {
return registry.replace(/\/$/, ``);
}

// TODO: Remove the fallback on publishConfig
export function getAuditRegistry(manifest: Manifest, {configuration}: {configuration: Configuration}) {
return getDefaultRegistry({configuration, type: RegistryType.AUDIT_REGISTRY});
const defaultRegistry = configuration.get(RegistryType.AUDIT_REGISTRY);
if (defaultRegistry !== null)
return normalizeRegistry(defaultRegistry);

return getPublishRegistry(manifest, {configuration});
}

export function getPublishRegistry(manifest: Manifest, {configuration}: {configuration: Configuration}) {
Expand Down