Skip to content

fix: revert breaking changes from conditional dependencies #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 3 commits into from
Oct 22, 2021
Merged

fix: revert breaking changes from conditional dependencies #3612

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a7ed9d
fix: revert breaking change to cache and fetchers
merceyz Oct 21, 2021
58f0fe1
fix: make `conditions` optional
merceyz Oct 21, 2021
8dcf500
fix: handle undefined `conditions`
merceyz Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: handle undefined conditions
  • Loading branch information
@merceyz
merceyz committed Oct 21, 2021
commit 8dcf500d968e942970e85ac5955ff16c28c42f46
2 changes: 1 addition & 1 deletion packages/plugin-pnp/sources/PnpLinker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ export class PnpInstaller implements Installer {
if (FORCED_UNPLUG_PACKAGES.has(pkg.identHash))
return true;

if (pkg.conditions !== null)
if (pkg.conditions != null)
return true;

if (customPackageData.manifest.preferUnplugged !== null)
Expand Down
2 changes: 1 addition & 1 deletion packages/yarnpkg-core/sources/Project.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,7 +850,7 @@ export class Project {
const disabledLocators = new Set<LocatorHash>();

for (const pkg of allPackages.values()) {
if (pkg.conditions === null)
if (pkg.conditions == null)
continue;

if (!optionalBuilds.has(pkg.locatorHash))
Expand Down