Skip to content

Enables all official plugins by default #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 25 commits into from
Mar 29, 2022
Merged

Enables all official plugins by default #4253

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d162825
wip
arcanis Mar 22, 2022
d340a85
Enables all plugins by default
arcanis Mar 22, 2022
f1325da
Lazy-loads packages
arcanis Mar 22, 2022
5e3bdea
Only adds @types/ packages if the project has a tsconfig
arcanis Mar 23, 2022
ad69b79
Removes debug
arcanis Mar 23, 2022
f9a9b76
Fixes lint
arcanis Mar 23, 2022
4e7d0e4
Adds a configuration option for @types auto-adds
arcanis Mar 23, 2022
aaaca27
Fixes tests
arcanis Mar 23, 2022
0ffce57
Removes plugin configuration from the tests
arcanis Mar 23, 2022
d0bdfb9
Fixes linting
arcanis Mar 24, 2022
257003b
Removes plugins from the scripts directory
arcanis Mar 25, 2022
3be3870
Removes checked-in plugins
arcanis Mar 25, 2022
34b2a50
Removes plugins from the yaml database
arcanis Mar 25, 2022
ddb506c
Removes the update-local scripts
arcanis Mar 25, 2022
3edd606
Removes the plugin build from the CI
arcanis Mar 25, 2022
2ee923d
Disables auto types removal if tsEnableAutoTypes is set
arcanis Mar 25, 2022
1a64295
Updates readme
arcanis Mar 25, 2022
5520b90
Simplifies rc build
arcanis Mar 25, 2022
4333a68
Fixes plugins.yml
arcanis Mar 28, 2022
ec9034e
Fixes tests
arcanis Mar 29, 2022
0953ab4
Fixes tests
arcanis Mar 29, 2022
184ca88
Adds debug workflow
arcanis Mar 29, 2022
2dfde10
Removes yup
arcanis Mar 29, 2022
8b1d63f
Cancels the debug job on repeated triggers
arcanis Mar 29, 2022
0f0c94d
Merge remote-tracking branch 'origin/master' into mael/all-the-plugins
arcanis Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes tests
  • Loading branch information
@arcanis
arcanis committed Mar 23, 2022
commit aaaca2785c9a12b565759f56d90b8dca4758842a
97 changes: 67 additions & 30 deletions packages/acceptance-tests/pkg-tests-specs/sources/plugins/plugin-typescript.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import {Manifest} from '@yarnpkg/core';
import {PortablePath} from '@yarnpkg/fslib';
import {merge} from 'lodash';
import {fs, yarn} from 'pkg-tests-core';
import {Manifest} from '@yarnpkg/core';
import {Filename, PortablePath, ppath, xfs} from '@yarnpkg/fslib';
import {merge} from 'lodash';
import {fs, yarn} from 'pkg-tests-core';

const {unpackToDirectory} = fs;
const {writeConfiguration, readManifest} = yarn;
Expand All @@ -10,9 +10,45 @@ describe(`Plugins`, () => {
describe(`typescript`, () => {
describe(`Adding types`, () => {
test(
`it should automatically add @types to devDependencies when package doesn't provide types`,
`it shouldn't be enabled by default`,
makeTemporaryEnv({}, async ({path, run, source}) => {
await run(`add`, `is-number`);

const manifestPromise = readManifest(path);

await expect(manifestPromise).resolves.toMatchObject({
dependencies: {
[`is-number`]: `^2.0.0`,
},
});

await expect(manifestPromise).not.toHaveProperty(`devDependencies`);
}),
);

test(
`it should automatically enable automatic @types insertion when a tsconfig is detected`,
makeTemporaryEnv({}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});
await xfs.writeFilePromise(ppath.join(path, `tsconfig.json` as Filename), ``);

await run(`add`, `is-number`);

await expect(readManifest(path)).resolves.toMatchObject({
dependencies: {
[`is-number`]: `^2.0.0`,
},
devDependencies: {
[`@types/is-number`]: `^2`,
},
});
}),
);

test(
`it should automatically add @types to devDependencies when package doesn't provide types`,
makeTemporaryEnv({}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await run(`add`, `is-number`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand All @@ -28,8 +64,9 @@ describe(`Plugins`, () => {

test(
`it should not add @types when package provides its own types`,
makeTemporaryEnv({}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});
makeTemporaryEnv({}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await run(`add`, `left-pad`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand All @@ -42,8 +79,9 @@ describe(`Plugins`, () => {

test(
`it should automatically add @types for scoped packages`,
makeTemporaryEnv({}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});
makeTemporaryEnv({}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await run(`add`, `@iarna/toml`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand All @@ -59,8 +97,9 @@ describe(`Plugins`, () => {

test(
`it should not generate a @types dependency if @types package doesn't exist`,
makeTemporaryEnv({}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});
makeTemporaryEnv({}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await run(`add`, `resolve`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand All @@ -73,8 +112,9 @@ describe(`Plugins`, () => {

test(
`it should not add @types for transient dependencies`,
makeTemporaryEnv({}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});
makeTemporaryEnv({}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await run(`add`, `one-fixed-dep-with-types`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand All @@ -87,8 +127,9 @@ describe(`Plugins`, () => {

test(
`it should add @types with the range '^<original-major>' by default`,
makeTemporaryEnv({}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});
makeTemporaryEnv({}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await run(`add`, `is-number@^1.0.0`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand All @@ -115,9 +156,9 @@ describe(`Plugins`, () => {
[`@types/is-number`]: `1.0.0`,
},
},
}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});

await run(`add`, `is-number@^2.0.0`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand Down Expand Up @@ -147,9 +188,9 @@ describe(`Plugins`, () => {
[`@types/is-number`]: `1.0.0`,
},
},
}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});

await run(`add`, `is-number@^2.0.0`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand All @@ -176,9 +217,9 @@ describe(`Plugins`, () => {
[`@types/is-number`]: `1.0.0`,
},
},
}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});

await run(`add`, `is-number@^2.0.0`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand All @@ -202,9 +243,9 @@ describe(`Plugins`, () => {
[`is-number`]: `^1.0.0`,
},
},
}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});

await run(`add`, `is-number@^1.0.0`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand Down Expand Up @@ -236,9 +277,9 @@ describe(`Plugins`, () => {
[`@types/is-number`]: `2.0.0`,
},
},
}, {
tsEnableAutoTypes: true,
}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});

await run(`add`, `is-number@^2.0.0`);

await expect(readManifest(path)).resolves.toMatchObject({
Expand Down Expand Up @@ -266,7 +307,6 @@ describe(`Plugins`, () => {
[`@types/is-number`]: `1.0.0`,
},
}), async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});
await run(`remove`, `is-number`);

await expect(readManifest(path)).resolves.not.toHaveProperty(`${type}.@types/is-number`);
Expand All @@ -284,7 +324,6 @@ describe(`Plugins`, () => {
[`@types/iarna__toml`]: `1.0.0`,
},
}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});
await run(`remove`, `@iarna/toml`);

await expect(readManifest(path)).resolves.not.toHaveProperty(`devDependencies.@types/iarna__toml`);
Expand All @@ -303,8 +342,6 @@ describe(`Plugins`, () => {
typings: `./published-typings.d.ts`,
},
}, async ({path, run, source}) => {
await writeConfiguration(path, {plugins: [require.resolve(`@yarnpkg/monorepo/scripts/plugin-typescript.js`)]});

await run(`install`);
await run(`pack`);

Expand Down