Skip to content

Implements --check-resolutions #4302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 3 commits into from
Mar 31, 2022
Merged

Implements --check-resolutions #4302

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ce30d9
Implements --check-resolutions
arcanis Mar 31, 2022
d4f4862
Fixes tests
arcanis Mar 31, 2022
b34398a
Adds documentation
arcanis Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes tests
  • Loading branch information
@arcanis
arcanis committed Mar 31, 2022
commit d4f4862893deee10cd7296ce57d3b9974255bbda
2 changes: 0 additions & 2 deletions packages/acceptance-tests/pkg-tests-specs/sources/features/checkResolutions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ describe(`Features`, () => {

await xfs.writeJsonPromise(manifestPath, manifestData);

throw new Error(42);

const check = run(`install`, `--check-resolutions`);
if (valid) {
await check;
Expand Down
13 changes: 8 additions & 5 deletions packages/plugin-npm/tests/NpmSemverResolver.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,19 @@ describe(`NpmSemverResolver`, () => {
it(`should match when the reference contains a __archiveUrl`, async () => {
const resolver = new NpmSemverResolver();

const reference = `npm:1.0.0::__archiveUrl=foo.tgz`;
const ident = structUtils.makeIdent(null, `foo`);
const descriptor = structUtils.makeDescriptor(ident, `npm:*`);
const locator = structUtils.makeLocator(ident, `npm:1.0.0::__archiveUrl=foo.tgz`);

const results = await resolver.getSatisfying(
structUtils.makeDescriptor(structUtils.makeIdent(null, `foo`), `*`),
[reference],
descriptor,
{},
[locator],
null as any,
);

expect(results.length).toEqual(1);
expect(results[0].reference).toEqual(reference);
expect(results.locators.length).toEqual(1);
expect(results.locators[0].locatorHash).toEqual(locator.locatorHash);
});
});
});