Skip to content

Conversation

@hughdavenport
Copy link
Contributor

Fixes #4348, where yarn install was not working.

How did you fix it?
Replaced ~/.yarn with ./.yarn.

Checklist

@hughdavenport
Copy link
Contributor Author

Hey folks, sorry some of the tests are failing and I'm not sure how to fix them. I ran a yarn install after and committed that, but they still seem to complain about needing to do a yarn install. I can build the artifacts locally on a clean git (see below).

Any help is appreciated. I was hoping this would be an easy patch :)

16:42 $ node ./scripts/run-yarn.js build:cli --no-minify
➤ YN0000: ┌ Building the CLI
➤ YN0000: │ pnp:/home/hugh/src/berry/.yarn/__virtual__/ws-virtual-4ae8332061/0/cache/ws-npm-7.4.6-9c9a725604-3a990b32ed.zip/node_modules/ws/lib/buffer-util.js:105:29
➤ YN0000: │    ↳ ws tried to access bufferutil (a peer dependency) but it isn't provided by its ancestors; this makes the require call ambiguous and unsound.

Required package: bufferutil
Required by: ws@virtual:4ac7945935c7b9baa1c648c30910b97cc4b5310bd9c6e7f82899f24717f03acba3019fca67c456aeaef29db72c35d787ebde17b426ca35ee56f8bb84bc683d77#npm:7.4.6 (via /home/hugh/src/berry/.yarn/__virtual__/ws-virtual-4ae8332061/0/cache/ws-npm-7.4.6-9c9a725604-3a990b32ed.zip/node_modules/ws/lib/buffer-util.js)

Ancestor breaking the chain: engine.io@npm:4.1.1
Ancestor breaking the chain: engine.io-client@npm:4.1.4
Ancestor breaking the chain: gatsby-recipes@virtual:bb88b764d61450132be48213823d70f9bf21be835d1fee86847bf6ff769cadb0cb285a391ca1b78b66390679c323d981c72cf063410df0964fa023366247de16#npm:0.25.0
Ancestor breaking the chain: ink@virtual:8d898fef98e932beba43b4d6618011f697787e7fd2f52624eb7daef58d4ae47c2c0be4a00e4cbfbae536ebdaf948ef2fd37ad5cb2fa89c56ad66c9e7ff10f073#patch:ink@npm%3A3.0.8#./.yarn/patches/ink-npm-3.0.8-3a8005f59f.patch::version=3.0.8&hash=1e50c6&locator=%40yarnpkg%2Fmonorepo%40workspace%3A.
Ancestor breaking the chain: jsdom@virtual:cb8d5b0375dc18902a2ec8160a6264a401f7cf27353fbeda5798c17ddcfc36f9aa268bde2fcdcf6275c36c016cfa0ad548376b6dd4f27fbe8fafac18f5c94a36#npm:16.2.2
Ancestor breaking the chain: react-devtools-core@npm:4.9.0
Ancestor breaking the chain: subscriptions-transport-ws@virtual:49727782733e463351ec2922a482668492b16639b063f656977fdbfe395eca71e3548ad1fe4715a050ea1cade7d007e25417accdd0e88408e3a2ccccfdaf51ac#npm:0.9.19


➤ YN0000: │ pnp:/home/hugh/src/berry/.yarn/__virtual__/ws-virtual-4ae8332061/0/cache/ws-npm-7.4.6-9c9a725604-3a990b32ed.zip/node_modules/ws/lib/validation.js:86:28
➤ YN0000: │    ↳ ws tried to access utf-8-validate (a peer dependency) but it isn't provided by its ancestors; this makes the require call ambiguous and unsound.

Required package: utf-8-validate
Required by: ws@virtual:4ac7945935c7b9baa1c648c30910b97cc4b5310bd9c6e7f82899f24717f03acba3019fca67c456aeaef29db72c35d787ebde17b426ca35ee56f8bb84bc683d77#npm:7.4.6 (via /home/hugh/src/berry/.yarn/__virtual__/ws-virtual-4ae8332061/0/cache/ws-npm-7.4.6-9c9a725604-3a990b32ed.zip/node_modules/ws/lib/validation.js)

Ancestor breaking the chain: engine.io@npm:4.1.1
Ancestor breaking the chain: engine.io-client@npm:4.1.4
Ancestor breaking the chain: gatsby-recipes@virtual:bb88b764d61450132be48213823d70f9bf21be835d1fee86847bf6ff769cadb0cb285a391ca1b78b66390679c323d981c72cf063410df0964fa023366247de16#npm:0.25.0
Ancestor breaking the chain: ink@virtual:8d898fef98e932beba43b4d6618011f697787e7fd2f52624eb7daef58d4ae47c2c0be4a00e4cbfbae536ebdaf948ef2fd37ad5cb2fa89c56ad66c9e7ff10f073#patch:ink@npm%3A3.0.8#./.yarn/patches/ink-npm-3.0.8-3a8005f59f.patch::version=3.0.8&hash=1e50c6&locator=%40yarnpkg%2Fmonorepo%40workspace%3A.
Ancestor breaking the chain: jsdom@virtual:cb8d5b0375dc18902a2ec8160a6264a401f7cf27353fbeda5798c17ddcfc36f9aa268bde2fcdcf6275c36c016cfa0ad548376b6dd4f27fbe8fafac18f5c94a36#npm:16.2.2
Ancestor breaking the chain: react-devtools-core@npm:4.9.0
Ancestor breaking the chain: subscriptions-transport-ws@virtual:49727782733e463351ec2922a482668492b16639b063f656977fdbfe395eca71e3548ad1fe4715a050ea1cade7d007e25417accdd0e88408e3a2ccccfdaf51ac#npm:0.9.19


➤ YN0000: │ pnp:/home/hugh/src/berry/packages/yarnpkg-core/sources/miscUtils.ts:322:33
➤ YN0000: │    ↳ Using direct eval with a bundler is not recommended and may cause problems (more info: https://esbuild.github.io/link/direct-eval)
➤ YN0000: │ pnp:/home/hugh/src/berry/packages/yarnpkg-core/sources/miscUtils.ts:343:26
➤ YN0000: │    ↳ Using direct eval with a bundler is not recommended and may cause problems (more info: https://esbuild.github.io/link/direct-eval)
➤ YN0000: └ Completed in 6s 694ms

➤ YN0000: ✓ Done building the CLI!
➤ YN0000: ? Bundle path: /home/hugh/src/berry/packages/yarnpkg-cli/bundles/yarn.js
➤ YN0000: ? Bundle size: 6.53 MB
➤ YN0000: ? Bundle version: 4.0.0-rc.2.git.20220413.hash-73f15f35e

➤ YN0000: → @yarnpkg/plugin-essentials
➤ YN0000: → @yarnpkg/plugin-compat
➤ YN0000: → @yarnpkg/plugin-constraints
➤ YN0000: → @yarnpkg/plugin-dlx
➤ YN0000: → @yarnpkg/plugin-exec
➤ YN0000: → @yarnpkg/plugin-file
➤ YN0000: → @yarnpkg/plugin-git
➤ YN0000: → @yarnpkg/plugin-github
➤ YN0000: → @yarnpkg/plugin-http
➤ YN0000: → @yarnpkg/plugin-init
➤ YN0000: → @yarnpkg/plugin-interactive-tools
➤ YN0000: → @yarnpkg/plugin-link
➤ YN0000: → @yarnpkg/plugin-nm
➤ YN0000: → @yarnpkg/plugin-npm
➤ YN0000: → @yarnpkg/plugin-npm-cli
➤ YN0000: → @yarnpkg/plugin-pack
➤ YN0000: → @yarnpkg/plugin-patch
➤ YN0000: → @yarnpkg/plugin-pnp
➤ YN0000: → @yarnpkg/plugin-pnpm
➤ YN0000: → @yarnpkg/plugin-stage
➤ YN0000: → @yarnpkg/plugin-typescript
➤ YN0000: → @yarnpkg/plugin-version
➤ YN0000: → @yarnpkg/plugin-workspace-tools

hugh@LIN-PF-34NZV3: ~/src/berry on patch-1 [tag:2022-04-12-3-g73f15f35e]
16:44 $ node ./scripts/run-yarn.js package:vscode-zipfs
Executing prepublish script 'yarn run vscode:prepublish'...

./sources/index.ts → ./build/index.js...
created ./build/index.js in 4.5s
 DONE  Packaged: /home/hugh/src/berry/packages/vscode-zipfs/vscode-zipfs-3.0.0-rc.2.vsix (7 files, 140.84KB)
 INFO
The latest version of vsce is 2.7.0 and you have 1.85.1.
Update it now: npm install -g vsce

@hughdavenport hughdavenport changed the title Fixes #4348 Fix yarn install on master Apr 14, 2022
@merceyz
Copy link
Member

merceyz commented Apr 25, 2022

Replaced ~/.yarn with ./.yarn.

Closing as that is valid in this context, see:

Patches can now reference paths via the ~/ prefix, in which case it'll be relative to the project root
#4218


It looks like you've run yarn set version in your home directory which is causing that version to be used instead of the one in this repo. Check ~/.yarnrc(.yml) for yarnPath and remove it.

Ref #4350 (comment)

@merceyz merceyz closed this Apr 25, 2022
@hughdavenport hughdavenport deleted the patch-1 branch April 25, 2022 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug?]: Unable to yarn install on master

2 participants