Skip to content

fix(core): don't normalize package extension peer dependency ranges #4588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 1 commit into from
Jun 30, 2022
Merged

fix(core): don't normalize package extension peer dependency ranges #4588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .yarn/versions/84c234d6.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
releases:
"@yarnpkg/cli": patch
"@yarnpkg/core": patch

declined:
- "@yarnpkg/plugin-compat"
- "@yarnpkg/plugin-constraints"
- "@yarnpkg/plugin-dlx"
- "@yarnpkg/plugin-essentials"
- "@yarnpkg/plugin-exec"
- "@yarnpkg/plugin-file"
- "@yarnpkg/plugin-git"
- "@yarnpkg/plugin-github"
- "@yarnpkg/plugin-http"
- "@yarnpkg/plugin-init"
- "@yarnpkg/plugin-interactive-tools"
- "@yarnpkg/plugin-link"
- "@yarnpkg/plugin-nm"
- "@yarnpkg/plugin-npm"
- "@yarnpkg/plugin-npm-cli"
- "@yarnpkg/plugin-pack"
- "@yarnpkg/plugin-patch"
- "@yarnpkg/plugin-pnp"
- "@yarnpkg/plugin-pnpm"
- "@yarnpkg/plugin-stage"
- "@yarnpkg/plugin-typescript"
- "@yarnpkg/plugin-version"
- "@yarnpkg/plugin-workspace-tools"
- "@yarnpkg/builder"
- "@yarnpkg/doctor"
- "@yarnpkg/extensions"
- "@yarnpkg/nm"
- "@yarnpkg/pnpify"
- "@yarnpkg/sdks"
6 changes: 5 additions & 1 deletion packages/acceptance-tests/pkg-tests-specs/sources/features/packageExtensions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ describe(`Features`, () => {
},
});

await run(`install`);
await expect(run(`install`)).resolves.toMatchObject({
// Makes sure that the packageExtension peerDependency range hasn't accidentally
// been altered / normalized and that the installed package is compatible with it.
stdout: expect.not.stringContaining(`YN0060`),
});

await expect(source(`require('various-requires/invalid-require')`)).resolves.toMatchObject({
name: `no-deps`,
Expand Down
2 changes: 1 addition & 1 deletion packages/yarnpkg-core/sources/Configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,7 +1613,7 @@ export class Configuration {
const currentPeerDependency = pkg.peerDependencies.get(extension.descriptor.identHash);
if (typeof currentPeerDependency === `undefined`) {
extension.status = PackageExtensionStatus.Active;
pkg.peerDependencies.set(extension.descriptor.identHash, this.normalizeDependency(extension.descriptor));
pkg.peerDependencies.set(extension.descriptor.identHash, extension.descriptor);
}
} break;

Expand Down