Skip to content

refactor(core)!: remove MapConfigurationValue #4645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 2 commits into from
Jul 20, 2022
Merged

refactor(core)!: remove MapConfigurationValue #4645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d0899f
refactor(core)!: remove `MapConfigurationValue`
paul-soporan Jul 20, 2022
036cb87
Merge branch 'master' into paul/refactor/remove-map-configuration-value
arcanis Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .yarn/versions/d4c190fa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
releases:
"@yarnpkg/core": major

declined:
- "@yarnpkg/plugin-compat"
- "@yarnpkg/plugin-constraints"
- "@yarnpkg/plugin-dlx"
- "@yarnpkg/plugin-essentials"
- "@yarnpkg/plugin-exec"
- "@yarnpkg/plugin-file"
- "@yarnpkg/plugin-git"
- "@yarnpkg/plugin-github"
- "@yarnpkg/plugin-http"
- "@yarnpkg/plugin-init"
- "@yarnpkg/plugin-interactive-tools"
- "@yarnpkg/plugin-link"
- "@yarnpkg/plugin-nm"
- "@yarnpkg/plugin-npm"
- "@yarnpkg/plugin-npm-cli"
- "@yarnpkg/plugin-pack"
- "@yarnpkg/plugin-patch"
- "@yarnpkg/plugin-pnp"
- "@yarnpkg/plugin-pnpm"
- "@yarnpkg/plugin-stage"
- "@yarnpkg/plugin-typescript"
- "@yarnpkg/plugin-version"
- "@yarnpkg/plugin-workspace-tools"
- "@yarnpkg/builder"
- "@yarnpkg/cli"
- "@yarnpkg/doctor"
- "@yarnpkg/extensions"
- "@yarnpkg/nm"
- "@yarnpkg/pnpify"
- "@yarnpkg/sdks"
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ The following changes only affect people writing Yarn plugins:

- `npmConfigUtils.getAuditRegistry` no longer takes a `Manifest` as its first argument.

- `MapConfigurationValue` has been removed. Use `miscUtils.ToMapValue` instead.

- `Manifest.isManifestFieldCompatible` and `Manifest.prototype.isCompatibleWith{OS,CPU}` have been removed. Use `Manifest.prototype.getConditions` and `structUtils.isPackageCompatible` instead.

- `versionUtils.{fetchBase,fetchRoot,fetchChangedFiles}` have been moved from `@yarnpkg/plugin-version` to `@yarnpkg/plugin-git`. Use `gitUtils.{fetchBase,fetchRoot,fetchChangedFiles}` instead.
Expand Down
5 changes: 0 additions & 5 deletions packages/yarnpkg-core/sources/Configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,11 +546,6 @@ export const coreDefinitions: {[coreSettingName: string]: SettingsDefinition} =
},
};

/**
* @deprecated Use miscUtils.ToMapValue
*/
export type MapConfigurationValue<T extends object> = miscUtils.ToMapValue<T>;

export interface ConfigurationValueMap {
lastUpdateCheck: string | null;

Expand Down
2 changes: 1 addition & 1 deletion packages/yarnpkg-core/sources/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import * as treeUtils from './treeUtils';
export {Cache} from './Cache';
export {DEFAULT_RC_FILENAME, DEFAULT_LOCK_FILENAME, TAG_REGEXP} from './Configuration';
export {Configuration, FormatType, ProjectLookup, SettingsType} from './Configuration';
export type {PluginConfiguration, SettingsDefinition, MapConfigurationValue, PackageExtensionData} from './Configuration';
export type {PluginConfiguration, SettingsDefinition, PackageExtensionData} from './Configuration';
export type {ConfigurationValueMap, ConfigurationDefinitionMap} from './Configuration';
export type {Fetcher, FetchOptions, FetchResult, MinimalFetchOptions} from './Fetcher';
export {BuildType} from './Installer';
Expand Down