Skip to content

Writes a PnP spec #4671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 12 commits into from
Aug 4, 2022
Merged

Writes a PnP spec #4671

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
82f45d1
Writes a PnP spec
arcanis Jul 26, 2022
b62a1b6
Formalizes the algorithms
arcanis Jul 27, 2022
c3d5696
Updates the PnP header
arcanis Jul 27, 2022
c968909
Addresses feedbacks from https://github.com/evanw/esbuild/pull/1985
arcanis Jul 28, 2022
7ca80ec
Starts writing reusable tests
arcanis Jul 28, 2022
26c0616
More tests, clarifications on FIND_PNP_MANIFEST
arcanis Jul 28, 2022
64db5a5
Updates style for code segments
arcanis Jul 28, 2022
5abc9da
Adds tests for aliases
arcanis Jul 28, 2022
33040bd
Merge remote-tracking branch 'origin/master' into mael/pnp-spec
arcanis Aug 4, 2022
a1eb10b
Fixes inadvertent default setting change
arcanis Aug 4, 2022
443d09c
Fixes tests
arcanis Aug 4, 2022
194dae7
Versions
arcanis Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixes tests
  • Loading branch information
@arcanis
arcanis committed Aug 4, 2022
commit 443d09cd2417e21097a50cd77ace38f71a5d14fd
11 changes: 5 additions & 6 deletions .pnp.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/yarnpkg-pnp/sources/hook.js
View file
Open in desktop

Large diffs are not rendered by default.

23 changes: 6 additions & 17 deletions packages/yarnpkg-pnp/tests/pnpStandardRunner.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,14 @@
import {FakeFS, Filename, npath, PortablePath, ppath, ZipFS} from '@yarnpkg/fslib';
import {getLibzipSync} from '@yarnpkg/libzip';
import {Filename, npath, PortablePath, ppath, ZipFS} from '@yarnpkg/fslib';
import {getLibzipSync} from '@yarnpkg/libzip';

import {hydratePnpFile} from '../sources';
import {hydratePnpFile} from '../sources';

import expectations from './testExpectations.json';

const withMemoryFs = async (cb: (fs: FakeFS<PortablePath>) => Promise<void>) => {
const fs = new ZipFS(null, {
libzip: getLibzipSync(),
});

try {
await cb(fs);
} catch (err) {
fs.discardAndClose();
throw err;
}
};
import expectations from './testExpectations.json';

const projectRoot = `/path/to/project` as PortablePath;

process.env.PNP_DEBUG_LEVEL = `0`;

for (const {manifest, tests} of expectations) {
const fakeFs = new ZipFS(null, {
libzip: getLibzipSync(),
Expand Down