Skip to content

refactor(sdks)!: drop fallback on createRequireFromPath #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arcanis merged 1 commit into from
Aug 1, 2022
Merged

refactor(sdks)!: drop fallback on createRequireFromPath #4697

arcanis merged 1 commit into from
Aug 1, 2022

Conversation

@paul-soporan
Copy link
Member

@paul-soporan paul-soporan commented Aug 1, 2022

What's the problem this PR addresses?

createRequire has been available since Node v12.2.0 so there's no reason for us to fallback to createRequireFromPath.

How did you fix it?

Removed the fallback.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@paul-soporan paul-soporan enabled auto-merge (squash) August 1, 2022 12:05
@arcanis arcanis disabled auto-merge August 1, 2022 13:32
@arcanis arcanis merged commit b186b87 into master Aug 1, 2022
@arcanis arcanis deleted the paul/refactor/drop-createRequireFromPath branch August 1, 2022 13:32
@paul-soporan paul-soporan mentioned this pull request Aug 1, 2022
Closed
13 tasks
@jdanil jdanil mentioned this pull request Nov 13, 2022
Open
2 tasks
@merceyz merceyz added this to the 4.0.0 milestone May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merceyz merceyz merceyz approved these changes

Assignees

No one assigned

Labels

major

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@paul-soporan @merceyz @arcanis