Skip to content

Add export fields to manifests to prevent deep imports #4834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 11 commits into from
Sep 15, 2022
Merged

Add export fields to manifests to prevent deep imports #4834

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0aff756
Add `export` fields to manifests to prevent deep imports
Larry1123 Sep 8, 2022
c51cc09
fix test polyfills from failing to resolve
Larry1123 Sep 8, 2022
a4bbd11
fix two test files that were not importing right.
Larry1123 Sep 8, 2022
21c6fc0
temp workaround to rollup not supporting the exports right
Larry1123 Sep 8, 2022
c4c6a57
fix gatsby build
Larry1123 Sep 8, 2022
0bcd587
workaround for `pnp-esm.test.ts` failing to import
Larry1123 Sep 8, 2022
576c09a
fix imports in `prunedNativeDeps.test.ts`
Larry1123 Sep 8, 2022
856428a
fix `test-typescript-patch.js`
Larry1123 Sep 8, 2022
b2c2ad1
removed `./command/*` from exports
Larry1123 Sep 8, 2022
e99ee1f
remove `types` condition from `exports`
Larry1123 Sep 8, 2022
bd59b29
remove `types` in root and `publishConfig`
Larry1123 Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix test-typescript-patch.js 
make the `gatsby-node.js` fix more simple.
  • Loading branch information
@Larry1123
Larry1123 committed Sep 8, 2022
commit 856428a7bbd832e7c33d7fc1352076b861900ac7
3 changes: 1 addition & 2 deletions packages/gatsby/gatsby-plugin-yarn-introspection/gatsby-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,8 @@ exports.sourceNodes = async ({actions, createNodeId, createContentDigest}, opts)
}
});

const monorepoRoot = require.resolve(`@yarnpkg/monorepo/package.json`).replace(`/package.json`, ``);
const data = await execute([
require.resolve(`${monorepoRoot}/packages/yarnpkg-core/sources/Plugin.ts`),
require.resolve(path.resolve(packageDirectory, `yarnpkg-core/sources/Plugin.ts`)),
...indexList,
]);

Expand Down
15 changes: 9 additions & 6 deletions scripts/test-typescript-patch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,17 @@ const compilerOptions = ts.parseJsonSourceFileConfigFileContent(
const compilerHost = ts.createCompilerHost(compilerOptions);
const program = ts.createProgram(compilerOptions.fileNames, compilerOptions, compilerHost);
const moduleSpecifierResolutionHost = ts.createModuleSpecifierResolutionHost(program, compilerHost);
const rootSourceFile = program.getSourceFile(require.resolve(`@yarnpkg/core/sources/Project.ts`));

const yarnCorePkgDir = require.resolve(`@yarnpkg/core/package.json`).replace(`/package.json`, ``);
const fslibPkgDir = require.resolve(`@yarnpkg/fslib/package.json`).replace(`/package.json`, ``);
const rootSourceFile = program.getSourceFile(require.resolve(`${yarnCorePkgDir}/sources/Project.ts`));

const TESTS = [
[`@yarnpkg/core/sources/Configuration.ts`, `./Configuration`],
[`@yarnpkg/fslib/README.md`, `@yarnpkg/fslib/README.md`],
[`@yarnpkg/fslib/package.json`, `@yarnpkg/fslib/package.json`],
[`@yarnpkg/fslib/sources/ZipFS.ts`, `@yarnpkg/fslib/sources/ZipFS`],
[`@yarnpkg/fslib/sources/index.ts`, `@yarnpkg/fslib`],
[`${yarnCorePkgDir}/sources/Configuration.ts`, `./Configuration`],
[`${fslibPkgDir}/README.md`, `@yarnpkg/fslib/README.md`],
[`${fslibPkgDir}/package.json`, `@yarnpkg/fslib/package.json`],
[`${fslibPkgDir}/sources/ZipFS.ts`, `@yarnpkg/fslib/sources/ZipFS`],
[`${fslibPkgDir}/sources/index.ts`, `@yarnpkg/fslib`],
];

for (const [test, expected] of TESTS) {
Expand Down