refactor!: cleanup lutimes

.yarn/versions/57a58394.yml

@@ -0,0 +1,39 @@
+releases:
+  "@yarnpkg/cli": patch
+  "@yarnpkg/core": patch
+  "@yarnpkg/fslib": major
+  "@yarnpkg/plugin-patch": patch
+  "@yarnpkg/pnp": patch
+  "@yarnpkg/pnpify": patch
+
+declined:
+  - "@yarnpkg/plugin-compat"
+  - "@yarnpkg/plugin-constraints"
+  - "@yarnpkg/plugin-dlx"
+  - "@yarnpkg/plugin-essentials"
+  - "@yarnpkg/plugin-exec"
+  - "@yarnpkg/plugin-file"
+  - "@yarnpkg/plugin-git"
+  - "@yarnpkg/plugin-github"
+  - "@yarnpkg/plugin-http"
+  - "@yarnpkg/plugin-init"
+  - "@yarnpkg/plugin-interactive-tools"
+  - "@yarnpkg/plugin-link"
+  - "@yarnpkg/plugin-nm"
+  - "@yarnpkg/plugin-npm"
+  - "@yarnpkg/plugin-npm-cli"
+  - "@yarnpkg/plugin-pack"
+  - "@yarnpkg/plugin-pnp"
+  - "@yarnpkg/plugin-pnpm"
+  - "@yarnpkg/plugin-stage"
+  - "@yarnpkg/plugin-typescript"
+  - "@yarnpkg/plugin-version"
+  - "@yarnpkg/plugin-workspace-tools"
+  - vscode-zipfs
+  - "@yarnpkg/builder"
+  - "@yarnpkg/doctor"
+  - "@yarnpkg/extensions"
+  - "@yarnpkg/libzip"
+  - "@yarnpkg/nm"
+  - "@yarnpkg/sdks"
+  - "@yarnpkg/shell"

CHANGELOG.md

@@ -25,6 +25,7 @@ Yarn now accepts sponsorships! Please give a look at our [OpenCollective](https:
 - Yarn will no longer remove the old Yarn 2.x `.pnp.js` file when migrating.
 - The `pnpDataPath` option has been removed to adhere to our new [PnP specification](https://yarnpkg.com/advanced/pnp-spec). For consistency, all PnP files will now be hardcoded to a single value so that third-party tools can implement the PnP specification without relying on the Yarn configuration.
 - The `ZipFS` and `ZipOpenFS` classes have been moved from `@yarnpkg/fslib` to `@yarnpkg/libzip`. They no longer need or accept the `libzip` parameter.
+- Yarn now assumes that the `fs.lutimes` bindings are always available (which is true for all supported Node versions).
 
 ### **API Changes**
 
@@ -58,6 +59,8 @@ The following changes only affect people writing Yarn plugins:
   - `Link{Resolver,Fetcher}` have been renamed to `Portal{Resolver,Fetcher}`
   - `RawLink{Resolver,Fetcher}` have been renamed to `Link{Resolver,Fetcher}`
 
+- `FakeFS` classes are now required to implement `lutimes{Sync,Promise}`.
+
 ### Installs
 
 - The `pnpm` linker avoids creating symlinks that lead to loops on the file system, by moving them higher up in the directory structure.

packages/plugin-patch/sources/tools/apply.ts

@@ -11,13 +11,7 @@ async function preserveTime(baseFs: FakeFS<PortablePath>, p: PortablePath, cb: (
   if (typeof result !== `undefined`)
     p = result;
 
-  if (baseFs.lutimesPromise) {
-    await baseFs.lutimesPromise(p, stat.atime, stat.mtime);
-  } else if (!stat.isSymbolicLink()) {
-    await baseFs.utimesPromise(p, stat.atime, stat.mtime);
-  } else {
-    throw new Error(`Cannot preserve the time values of a symlink`);
-  }
+  await baseFs.lutimesPromise(p, stat.atime, stat.mtime);
 }
 
 export async function applyPatchFile(effects: ParsedPatchFile, {baseFs = new NodeFS(), dryRun = false, version = null}: {baseFs?: FakeFS<PortablePath>, dryRun?: boolean, version?: string | null} = {}) {

packages/yarnpkg-core/sources/tgzUtils.ts

@@ -134,7 +134,7 @@ export async function extractArchiveTo<T extends FakeFS<PortablePath>>(tgz: Buff
         targetFs.mkdirpSync(ppath.dirname(mappedPath), {chmod: 0o755, utimes: [constants.SAFE_TIME, constants.SAFE_TIME]});
 
         targetFs.symlinkSync((entry as any).linkpath, mappedPath);
-        targetFs.lutimesSync?.(mappedPath, constants.SAFE_TIME, constants.SAFE_TIME);
+        targetFs.lutimesSync(mappedPath, constants.SAFE_TIME, constants.SAFE_TIME);
       } break;
     }
   }

packages/yarnpkg-fslib/sources/FakeFS.ts

@@ -255,8 +255,8 @@ export abstract class FakeFS<P extends Path> {
   abstract utimesPromise(p: P, atime: Date | string | number, mtime: Date | string | number): Promise<void>;
   abstract utimesSync(p: P, atime: Date | string | number, mtime: Date | string | number): void;
 
-  lutimesPromise?(p: P, atime: Date | string | number, mtime: Date | string | number): Promise<void>;
-  lutimesSync?(p: P, atime: Date | string | number, mtime: Date | string | number): void;
+  abstract lutimesPromise(p: P, atime: Date | string | number, mtime: Date | string | number): Promise<void>;
+  abstract lutimesSync(p: P, atime: Date | string | number, mtime: Date | string | number): void;
 
   abstract readFilePromise(p: FSPath<P>, encoding?: null): Promise<Buffer>;
   abstract readFilePromise(p: FSPath<P>, encoding: BufferEncoding): Promise<string>;
@@ -731,11 +731,7 @@ export abstract class FakeFS<P extends Path> {
     if (typeof result !== `undefined`)
       p = result;
 
-    if (this.lutimesPromise) {
-      await this.lutimesPromise(p, stat.atime, stat.mtime);
-    } else if (!stat.isSymbolicLink()) {
-      await this.utimesPromise(p, stat.atime, stat.mtime);
-    }
+    await this.lutimesPromise(p, stat.atime, stat.mtime);
   }
 
   async preserveTimeSync(p: P, cb: () => P | void) {
@@ -745,11 +741,7 @@ export abstract class FakeFS<P extends Path> {
     if (typeof result !== `undefined`)
       p = result;
 
-    if (this.lutimesSync) {
-      this.lutimesSync(p, stat.atime, stat.mtime);
-    } else if (!stat.isSymbolicLink()) {
-      this.utimesSync(p, stat.atime, stat.mtime);
-    }
+    this.lutimesSync(p, stat.atime, stat.mtime);
   }
 }
 

packages/yarnpkg-fslib/sources/MountFS.ts

@@ -701,6 +701,22 @@ export class MountFS<MountedFS extends MountableFS> extends BasePortableFakeFS {
     });
   }
 
+  async lutimesPromise(p: PortablePath, atime: Date | string | number, mtime: Date | string | number) {
+    return await this.makeCallPromise(p, async () => {
+      return await this.baseFs.lutimesPromise(p, atime, mtime);
+    }, async (mountFs, {subPath}) => {
+      return await mountFs.lutimesPromise(subPath, atime, mtime);
+    });
+  }
+
+  lutimesSync(p: PortablePath, atime: Date | string | number, mtime: Date | string | number) {
+    return this.makeCallSync(p, () => {
+      return this.baseFs.lutimesSync(p, atime, mtime);
+    }, (mountFs, {subPath}) => {
+      return mountFs.lutimesSync(subPath, atime, mtime);
+    });
+  }
+
   async mkdirPromise(p: PortablePath, opts?: MkdirOptions) {
     return await this.makeCallPromise(p, async () => {
       return await this.baseFs.mkdirPromise(p, opts);

packages/yarnpkg-fslib/sources/NoFS.ts

@@ -238,6 +238,14 @@ export class NoFS extends FakeFS<PortablePath> {
     throw makeError();
   }
 
+  async lutimesPromise(): Promise<never> {
+    throw makeError();
+  }
+
+  lutimesSync(): never {
+    throw makeError();
+  }
+
   async readFilePromise(): Promise<never> {
     throw makeError();
   }