-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Bumps Node requirements from 14 to 18 #5445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ef2362d
Bumps Node requirements
arcanis 706739f
Versions
arcanis b390500
Removes getFormat / getSource
arcanis ecdc393
Updates the hook
arcanis fa65615
Removes the logic updates
arcanis f62c0d8
Revert "Removes the logic updates"
arcanis 6c7e6c0
Merge remote-tracking branch 'origin/master' into mael/bump-node-version
arcanis 77f6770
Update CHANGELOG.md
arcanis c773998
Artifacts from the merge
arcanis 4573433
Feedbacks
arcanis f516b09
Removes obsolete flags
arcanis c19d724
Merge branch 'master' into mael/bump-node-version
arcanis bc769af
Update integration-workflow.yml
arcanis 196c72f
Merge branch 'master' into mael/bump-node-version
merceyz a3f717b
chore: update artefacts
merceyz fc883aa
Update integration-workflow.yml
arcanis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "Removes the logic updates"
This reverts commit fa65615.
- Loading branch information
commit f62c0d85af7ae18af99cfb5c2ef5fc8f82eda9fe
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
23 changes: 0 additions & 23 deletions
23
packages/yarnpkg-pnp/sources/esm-loader/hooks/getFormat.ts
This file was deleted.
Oops, something went wrong.
19 changes: 0 additions & 19 deletions
19
packages/yarnpkg-pnp/sources/esm-loader/hooks/getSource.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,6 @@ | ||
| import {getFormat as getFormatHook} from './hooks/getFormat'; | ||
| import {getSource as getSourceHook} from './hooks/getSource'; | ||
| import {load as loadHook} from './hooks/load'; | ||
| import {resolve as resolveHook} from './hooks/resolve'; | ||
| import {HAS_CONSOLIDATED_HOOKS} from './loaderFlags'; | ||
| import {load as loadHook} from './hooks/load'; | ||
| import {resolve as resolveHook} from './hooks/resolve'; | ||
| import './fspatch'; | ||
|
|
||
| export const resolve = resolveHook; | ||
| export const getFormat = HAS_CONSOLIDATED_HOOKS ? undefined : getFormatHook; | ||
| export const getSource = HAS_CONSOLIDATED_HOOKS ? undefined : getSourceHook; | ||
| export const load = HAS_CONSOLIDATED_HOOKS ? loadHook : undefined; | ||
| export const load = loadHook; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to remove these flags since they'll always be true.