perf!: lazy load packageExtensions
#5608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Loading
packageExtensionsis currently done every single timeConfiguration.findis called, and it adds considerable overhead, both on everyyarninvocation and even more on commands that don't even use thepackageExtensions, such asyarn run.How did you fix it?
This PR gets rid of the
packageExtensionsfield and therefreshPackageExtensionsmethod in favor of aconfiguration.getPackageExtensionsasync method that caches the extensions and is called directly when needing access topackageExtensions.This change requiresSee review discussion.configuration.normalizePackageto becomeasync, but that's not a problem since all its callers areasync.Note:
packageExtensionscan't be a lazy getter becausepackageExtensionsneed to be loaded asynchronously.Benchmarks:
yarn -v:yarn workspaces foreach runChecklist