Makes Yarn compatible with Nodebox #5851
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
requested changes
Oct 24, 2023
| } | ||
|
|
||
| async persistInstallStateFile() { | ||
| if (!v8.serialize) |
Member
There was a problem hiding this comment.
Suggested change
| if (!v8.serialize) | |
| // TODO: Remove when Nodebox supports the v8 API | |
| if (!v8.serialize) |
Ideally with a link to an issue so we can track it.
Member
|
Unsure if we should be modifying Yarn to work with other runtimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The last blocker for running Yarn on Nodebox is the lack of
v8.serializesupport.How did you fix it?
Since the install state file is optional, we can just skip writing it.
Checklist