Skip to content

Conversation

@BasixKOR
Copy link
Contributor

@BasixKOR BasixKOR commented Aug 21, 2024

What's the problem this PR addresses?

Adresses #6329.

...

How did you fix it?

Add an option called --warnings and changed the behaviour of explainPeerRequirements to not print met peer requirements when the option is enabled,

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@BasixKOR
Copy link
Contributor Author

Some notes:

  • I don't mind bikeshedding on a flag name or variable name, please suggest better names as you see fit.
  • Do you think it is suitable to show warnings-only by default? I personally think it's reasonable but I kept it disabled by default since that would be a breaking change.

@BasixKOR BasixKOR requested a review from merceyz August 22, 2024 12:21
@clemyan
Copy link
Member

clemyan commented Aug 23, 2024

As I have said in #6329 (comment), the problem with this approach is that the flag is simply ignored in yarn explain peer-requirements --warnings p00000 and that can be confusing.

I don't mind it as a short-term solution but I think we still need to figure out a long-term solution

@merceyz merceyz dismissed their stale review August 24, 2024 12:54

Resolved

@BasixKOR
Copy link
Contributor Author

BasixKOR commented Aug 26, 2024

Thanks for the reference to #6329, I've updated the issue I opened to point there. While I do agree showing the unmet peer requirements would be more desirable it would be a breaqking change. I think adding this flag for the meantime makes sense as long as we can work on the solution for (potential) Yarn v5.

@mklemarczyk
Copy link

Any progress on the PR ? Current messages in peer-requirements are much less helpful than in yarn v1.

@BasixKOR
Copy link
Contributor Author

I should spend more time and add some tests to my PRs but I haven't gotten around to do so. Thanks for the reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants