Skip to content

feat: support OIDC auth for GitHub Actions/GitLab #6898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcanis merged 12 commits into from
Sep 18, 2025
+116 −12
Merged

feat: support OIDC auth for GitHub Actions/GitLab #6898

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d9b2a3a
feat: support OIDC auth for GitHub Actions/GitLab
cometkim Sep 13, 2025
82f58f3
prepare release
cometkim Sep 13, 2025
09b2407
fix
cometkim Sep 13, 2025
d2b5b66
request oidc token only on publishing
cometkim Sep 13, 2025
54d1528
fix
cometkim Sep 13, 2025
76fe4f6
make trusted publisher setting as optional
cometkim Sep 13, 2025
4951d0a
mark cli as minor
cometkim Sep 17, 2025
c568e5b
use process.env directly
cometkim Sep 17, 2025
e1ab5da
set OIDC audience to registry.npmjs.org
cometkim Sep 17, 2025
75fd4ff
fix audience
cometkim Sep 17, 2025
5addc9f
Versions
arcanis Sep 18, 2025
3730bf3
Merge branch 'master' into npm-trusted-publish
arcanis Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix
  • Loading branch information
@cometkim
cometkim committed Sep 17, 2025
commit 54d1528bde76f937dddbf74e8af1548cebf2385a
11 changes: 6 additions & 5 deletions packages/plugin-npm/sources/npmHttpUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,17 +466,18 @@ async function getAuthenticationHeader(registry: string, {authType = AuthType.CO
return `Basic ${npmAuthIdent}`;
}

if (mustAuthenticate && authType !== AuthType.BEST_EFFORT) {
throw new ReportError(MessageName.AUTHENTICATION_NOT_FOUND, `No authentication configured for request`);

} else if (allowOidc && ident) {
if (allowOidc && ident) {
const oidcToken = await getOidcToken(registry, {configuration, ident});
if (oidcToken) {
return `Bearer ${oidcToken}`;
}
}

return null;
if (mustAuthenticate && authType !== AuthType.BEST_EFFORT) {
throw new ReportError(MessageName.AUTHENTICATION_NOT_FOUND, `No authentication configured for request`);
} else {
return null;
}
}

function shouldAuthenticate(authConfiguration: MapLike, authType: AuthType) {
Expand Down