Skip to content

Conversation

@yoiang
Copy link
Contributor

@yoiang yoiang commented Sep 11, 2018

No description provided.

@codecov
Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #61 into master will decrease coverage by 8.2%.
The diff coverage is 41.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   94.57%   86.37%   -8.21%     
==========================================
  Files          11       11              
  Lines        1161     1372     +211     
==========================================
+ Hits         1098     1185      +87     
- Misses         63      187     +124
Impacted Files Coverage Δ
Sources/CSV/CSVReader.swift 64.72% <34.75%> (-27.98%) ⬇️
Tests/CSVTests/CSVTests.swift 90.96% <66.66%> (-9.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487816c...0669601. Read the comment docs.

@yaslab yaslab self-requested a review November 17, 2018 06:20
Copy link
Owner

@yaslab yaslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will add more tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants