Skip to content

[Speed] Add buffer to BinaryReader #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 17, 2018
Merged

[Speed] Add buffer to BinaryReader #65

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6a18924
[Speed] String.UnicodeScalarView#removeAll is slow
yaslab Nov 12, 2018
028bd2f
[Speed] Add buffer to BinaryReader
yaslab Nov 14, 2018
66945c0
Add BinaryReader Tests
yaslab Nov 15, 2018
826ce29
Update to Xcode 10.1
yaslab Nov 15, 2018
e12c86f
Avoid BOM
yaslab Nov 15, 2018
40a8f59
Use `|` instead of `+`
yaslab Nov 15, 2018
b01cbb3
Update _count and _position before break
yaslab Nov 15, 2018
1e83c6e
Merge branch 'master' into speed-up
yaslab Nov 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use | instead of +
  • Loading branch information
@yaslab
yaslab committed Nov 15, 2018
commit 40a8f59f88d5cbadc181ad77aab0fffe5797a343
12 changes: 6 additions & 6 deletions Tests/CSVTests/BinaryReaderTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class BinaryReaderTests: XCTestCase {
do {
let reader = try BinaryReader(stream: stream, endian: .big, closeOnDeinit: true, bufferSize: 7)
for i in stride(from: 0, to: bytes.count, by: 2) {
let expected = (UInt16(bytes[i]) << 8) + UInt16(bytes[i + 1])
let expected = (UInt16(bytes[i]) << 8) | UInt16(bytes[i + 1])
let actual = try reader.readUInt16()
XCTAssertEqual(actual, expected)
}
Expand All @@ -65,7 +65,7 @@ class BinaryReaderTests: XCTestCase {
do {
let reader = try BinaryReader(stream: stream, endian: .little, closeOnDeinit: true, bufferSize: 7)
for i in stride(from: 0, to: bytes.count, by: 2) {
let expected = UInt16(bytes[i]) + (UInt16(bytes[i + 1]) << 8)
let expected = UInt16(bytes[i]) | (UInt16(bytes[i + 1]) << 8)
let actual = try reader.readUInt16()
XCTAssertEqual(actual, expected)
}
Expand All @@ -82,8 +82,8 @@ class BinaryReaderTests: XCTestCase {
let reader = try BinaryReader(stream: stream, endian: .big, closeOnDeinit: true, bufferSize: 7)
for i in stride(from: 0, to: bytes.count, by: 4) {
let expected =
(UInt32(bytes[i ]) << 24) + (UInt32(bytes[i + 1]) << 16) +
(UInt32(bytes[i + 2]) << 8) + (UInt32(bytes[i + 3]) )
(UInt32(bytes[i ]) << 24) | (UInt32(bytes[i + 1]) << 16) |
(UInt32(bytes[i + 2]) << 8) | (UInt32(bytes[i + 3]) )
let actual = try reader.readUInt32()
XCTAssertEqual(actual, expected)
}
Expand All @@ -100,8 +100,8 @@ class BinaryReaderTests: XCTestCase {
let reader = try BinaryReader(stream: stream, endian: .little, closeOnDeinit: true, bufferSize: 7)
for i in stride(from: 0, to: bytes.count, by: 4) {
let expected =
(UInt32(bytes[i ]) ) + (UInt32(bytes[i + 1]) << 8) +
(UInt32(bytes[i + 2]) << 16) + (UInt32(bytes[i + 3]) << 24)
(UInt32(bytes[i ]) ) | (UInt32(bytes[i + 1]) << 8) |
(UInt32(bytes[i + 2]) << 16) | (UInt32(bytes[i + 3]) << 24)
let actual = try reader.readUInt32()
XCTAssertEqual(actual, expected)
}
Expand Down