Update project to Swift 5 and latest Xcode 10.2 settings #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=======================================
Coverage 90.75% 90.75%
=======================================
Files 14 14
Lines 1860 1860
=======================================
Hits 1688 1688
Misses 172 172
Continue to review full report at Codecov.
|
|
@yaslab Any chance to get this code reviewed and merged? :) |
|
Sorry for replying late. Thanks for working on Swift 5 support! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! Great library. 🙂 Would you mind accepting this PR to update to Swift 5 and the latest Xcode 10.2 settings?