Skip to content

Infinite recursion in ::Get #878

@fhoenig

Description

@fhoenig

You pass the params back into the same function....

Here is a fix:

inline Result ClientImpl::Get(const char *path, const Params &params,
                              const Headers &headers,
                              ResponseHandler response_handler,
                              ContentReceiver content_receiver,
                              Progress progress)
{
    if (params.empty()) {
        return Get(path, headers, response_handler, content_receiver, progress);
    }
    else
    {
        std::string path_with_query = detail::append_query_params(path, params);
        return Get(path_with_query.c_str(), {}, headers, response_handler,
                   content_receiver, progress);
    }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions