Skip to content

Minor fixes on test cases #1709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2023
Merged

Minor fixes on test cases #1709

merged 2 commits into from
Nov 12, 2023

Conversation

@jimmy-park
Copy link
Contributor

@jimmy-park jimmy-park commented Nov 11, 2023

  • SSLClientServerTest.SSLConnectTimeout has a data race when stopping the server. (detected by ThreadSanitizer)
  • After 7aba293, we don't need to wait the server using std::this_thread::sleep_for(). Just use Server::wait_until_ready().

@yhirose
Copy link
Owner

yhirose commented Nov 12, 2023

Thanks for simplifying the code.

@yhirose yhirose merged commit f143131 into yhirose:master Nov 12, 2023
@jimmy-park jimmy-park deleted the fix-test-case branch November 12, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmy-park @yhirose